Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UX to load MVT layers from style URL only #58663

Merged
merged 9 commits into from
Sep 12, 2024
Merged

add UX to load MVT layers from style URL only #58663

merged 9 commits into from
Sep 12, 2024

Conversation

3nids
Copy link
Member

@3nids 3nids commented Sep 11, 2024

Vector Tiles layers can now be loaded from the style only. The data source is then automatically parsed from the style, and multiple data sources are now supported.

For instance, loading the Swisstopo base layer with multiple data sources:

Screen.Recording.2024-09-11.at.16.21.27.mov

Here are a couple of screenshots before/after:
changelog-1
changelog-2
changelog-3

Funded by OPENGIS.ch

@3nids 3nids added Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. labels Sep 11, 2024
@qgis-bot
Copy link
Collaborator

@3nids
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@github-actions github-actions bot added this to the 3.40.0 milestone Sep 11, 2024
Copy link

github-actions bot commented Sep 11, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 7211c69)

@3nids 3nids requested a review from nirvn September 11, 2024 15:55
@3nids
Copy link
Member Author

3nids commented Sep 12, 2024

@nirvn following our discussion, I move the URI update from the constructor to app. It seems more consistent and safer indeed.

src/core/vectortile/qgsvectortileutils.h Outdated Show resolved Hide resolved
@3nids 3nids merged commit ea3d907 into qgis:master Sep 12, 2024
29 checks passed
@3nids 3nids deleted the mvt-ux branch September 12, 2024 14:31
@qgis-bot
Copy link
Collaborator

@3nids
A documentation ticket has been opened at qgis/QGIS-Documentation#9254
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

velle pushed a commit to velle/QGIS that referenced this pull request Sep 17, 2024
@zacharlie zacharlie added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Sep 24, 2024
@qgis-bot
Copy link
Collaborator

@3nids

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants