[ReshapeMapTool] Fix snapping matches with tracing #58779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troopa81
added
Map Tools
nyalldawson
added
Crash/Data Corruption
backport release-3_34
and removed
backport queued_ltr_backports
nyalldawson
reviewed
Sep 17, 2024
| addCurve( new QgsLineString( mapPoints ) ); | ||
| int pointBefore = mCaptureCurve.numPoints(); |
There was a problem hiding this comment.
Just to make it clearer what this is actually doing, could we move all the logic relating to pointBefore/pointAfter and the sync snapping matches into the block which starts with if ( QgsSettingsRegistryCore::settingsDigitizingConvertToCurve->value() ) ? As far as I can see this logic ONLY applies now if the curve approximation is happening.
And on that note... if the unsegmentized line ends up with LESS vertices then the segmentized one, won't mSnappingMatches have too many entries and need to be trimmed? Maybe this whole logic could be simplified down to just:
// sync the snapping matches list
mSnappingMatches.resize( mCaptureCurve.numPoints() )
There was a problem hiding this comment.
Good catch! Done c3c3ccc
When we need curve de-approximation
nyalldawson
reviewed
Sep 18, 2024
So we keep the existing snapping matches
nyalldawson
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addCurve()method already update themSnappingMatchesvariable so we need to updatepointBeforevariable after theaddCurve()callFixes #57225