Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Fix processing algorithms and models window's title when group name is empty #58837

Merged

Conversation

agiudiceandrea
Copy link
Contributor

@agiudiceandrea agiudiceandrea commented Sep 22, 2024

Description

This PR fixes

image

the incorrect window's title displayed when the group name of a model or of a processing algorithm is an empty string

image

This PR also adds the model's group name (if not an empty string) to the Model Designer window's title as Model Designer: Model name - Group name

image

Refs: #57739, #58502.

@github-actions github-actions bot added this to the 3.40.0 milestone Sep 22, 2024
@agiudiceandrea agiudiceandrea added Processing Relating to QGIS Processing framework or individual Processing algorithms GUI/UX Related to QGIS application GUI or User Experience Modeller backport queued_ltr_backports Queued Backports labels Sep 22, 2024
@agiudiceandrea
Copy link
Contributor Author

agiudiceandrea commented Sep 22, 2024

@DelazJ @m-kuhn, what do you think?

Copy link

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 7b2a868)

@nyalldawson nyalldawson merged commit e688fb1 into qgis:master Sep 23, 2024
44 checks passed
@agiudiceandrea agiudiceandrea deleted the fix-processing-modeler-windows-title branch September 23, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport queued_ltr_backports Queued Backports GUI/UX Related to QGIS application GUI or User Experience Modeller Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants