Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-3_34] Prevent calling findLayers when there is no legend->rootGroup (fix #57595) #59043

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

qgis-bot
Copy link
Collaborator

Backport #57596
Authored by: @jgrocha

jgrocha and others added 2 commits October 10, 2024 12:20
Co-authored-by: Alessandro Pasotti <elpaso@itopen.it>
@github-actions github-actions bot added this to the 3.35.0 milestone Oct 10, 2024
Copy link
Member

@wonder-sk wonder-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be safe to merge.

A client was getting crashes with some print layouts in 3.34.x with the same backtrace as in #57595, and confirmed the crashes are gone in 3.38.0.

@nyalldawson nyalldawson merged commit 790e3c2 into release-3_34 Oct 10, 2024
32 checks passed
@nyalldawson nyalldawson deleted the backport-57596-to-release-3_34 branch October 10, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants