allow to set specific settings editors + add test #59079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3nids
force-pushed
the
settings-editor-custom
branch
2 times, most recently
from
4977981 to
71469b5
Compare
3nids
force-pushed
the
settings-editor-custom
branch
from
71469b5 to
8640315
Compare
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nirvn
reviewed
Oct 15, 2024
nyalldawson
reviewed
Oct 23, 2024
nirvn
approved these changes
Oct 24, 2024
|
Postgres test failure seems unrelated and is currently happening on other PRs. |
nyalldawson
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a better approach to support custom settings editor widgets (this is the remaining part of #59006, and follow-up of #59014)
You can now specifiy a custom settings editor for a specific setting.
This also adds a test for the settings editor registry both for the automatic and custom cases.