Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh Render Extent Settings #59636

Merged
merged 22 commits into from
Dec 17, 2024
Merged

Conversation

JanCaha
Copy link
Contributor

@JanCaha JanCaha commented Nov 28, 2024

Description

This is iteration of #59305 which was changed a lot by introduction of changes in #59444.

This PR brings to renderer for Mesh Contours option to set renderer Min Max based on extent (specific canvas, changing canvas) in the same way as renderers for Raster Layer.

Besides that minimumMaximumActiveScalarDataset( const QgsRectangle &extent, const QgsMeshDatasetIndex &datasetIndex, double &min, double &max ) is added to MeshLayer to obtain Min Max from specific Scalar Dataset Index for given extent.

396460968-2db9cad8-ae86-4bfc-9b4b-f493926bb8f5

@github-actions github-actions bot added this to the 3.42.0 milestone Nov 28, 2024
Copy link

github-actions bot commented Nov 28, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 2945eb2)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 2945eb2)

@nyalldawson
Copy link
Collaborator

LGTM! @wonder-sk did you want to review this one too?

@DelazJ DelazJ added Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Dec 3, 2024
@qgis-bot
Copy link
Collaborator

qgis-bot commented Dec 3, 2024

@JanCaha
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

qgis-bot commented Dec 3, 2024

@JanCaha

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@wonder-sk
Copy link
Member

I think @uclaros will have a glance on this...

Copy link
Contributor

@uclaros uclaros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Just a couple of comments

src/core/mesh/qgsmeshrenderersettings.cpp Outdated Show resolved Hide resolved
src/gui/mesh/qgsmeshrendererscalarsettingswidget.cpp Outdated Show resolved Hide resolved
JanCaha and others added 3 commits December 12, 2024 12:00
Co-authored-by: Stefanos Natsis <uclaros@gmail.com>
@nyalldawson nyalldawson merged commit 2adaec6 into qgis:master Dec 17, 2024
31 checks passed
@qgis-bot
Copy link
Collaborator

@JanCaha
A documentation ticket has been opened at qgis/QGIS-Documentation#9487
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog Items that are queued to appear in the visual changelog - remove after harvesting Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants