Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix metadata:plugin_dependencies parsing #59852

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

T4mmi
Copy link
Contributor

@T4mmi T4mmi commented Dec 12, 2024

Description

When writing a plugin, adding multiple values to the plugin_depencies field of the metadata.txt raises false positive errors when whitespaces are inserted in the line. One is supposed to split dependencies using a , comma, but if whitespaces are inserted (which is the 'standard' syntax ... at least in python with pip) it missread the name (false leading/trailling whitespaces).

This patch only commits a .strip() addition to the name and version parsed

Exemple

current behavior:
plugin_dependencies = Plugin Reloader, QRestart # fails
plugin_dependencies = Plugin Reloader,QRestart # success

patched behavior:
plugin_dependencies = Plugin Reloader, QRestart # success
plugin_dependencies = Plugin Reloader,QRestart # success

@github-actions github-actions bot added this to the 3.42.0 milestone Dec 12, 2024
Copy link

github-actions bot commented Dec 13, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 59ca50f)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 59ca50f)

@nyalldawson nyalldawson reopened this Dec 14, 2024
@nyalldawson
Copy link
Collaborator

@T4mmi there's a number of failing tests as a result of this, can you check please?

@T4mmi
Copy link
Contributor Author

T4mmi commented Dec 20, 2024

Hi, I'll try ... it seems that providers test fails which is weired to me since I don't touch any of these parts :s
not used to github workflows and QGIS contribution beginner here

Copy link

github-actions bot commented Jan 4, 2025

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 4, 2025
@m-kuhn m-kuhn closed this Jan 4, 2025
@m-kuhn m-kuhn reopened this Jan 4, 2025
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 4, 2025
@T4mmi T4mmi force-pushed the BUG-Fix-plugin_dependencies-parser branch from 59ca50f to e871134 Compare January 6, 2025 08:52
@T4mmi T4mmi force-pushed the BUG-Fix-plugin_dependencies-parser branch from e871134 to a2cd540 Compare January 6, 2025 08:55
@T4mmi
Copy link
Contributor Author

T4mmi commented Jan 6, 2025

I think I corrected the failling test ...

@m-kuhn m-kuhn merged commit 906b4e8 into qgis:master Jan 6, 2025
3 checks passed
@T4mmi T4mmi deleted the BUG-Fix-plugin_dependencies-parser branch January 16, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants