-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix metadata:plugin_dependencies parsing #59852
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
@T4mmi there's a number of failing tests as a result of this, can you check please? |
Hi, I'll try ... it seems that providers test fails which is weired to me since I don't touch any of these parts :s |
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
59ca50f
to
e871134
Compare
e871134
to
a2cd540
Compare
I think I corrected the failling test ... |
Description
When writing a plugin, adding multiple values to the
plugin_depencies
field of themetadata.txt
raises false positive errors when whitespaces are inserted in the line. One is supposed to split dependencies using a,
comma, but if whitespaces are inserted (which is the 'standard' syntax ... at least in python with pip) it missread the name (false leading/trailling whitespaces).This patch only commits a
.strip()
addition to the name and version parsedExemple
current behavior:
plugin_dependencies = Plugin Reloader, QRestart
# failsplugin_dependencies = Plugin Reloader,QRestart
# successpatched behavior:
plugin_dependencies = Plugin Reloader, QRestart
# successplugin_dependencies = Plugin Reloader,QRestart
# success