Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3D] notify user if the 3D scene export failed #59919

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

ptitjano
Copy link
Contributor

Description

A message is now displayed to notify that the export failed.

@ptitjano ptitjano self-assigned this Dec 16, 2024
@ptitjano ptitjano added the 3D Relates to QGIS' 3D engine or rendering label Dec 16, 2024
@github-actions github-actions bot added this to the 3.42.0 milestone Dec 16, 2024
Copy link

github-actions bot commented Dec 16, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit e4793c1)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit e4793c1)

src/app/3d/qgs3dmapcanvaswidget.cpp Outdated Show resolved Hide resolved
src/app/3d/qgs3dmapcanvaswidget.cpp Outdated Show resolved Hide resolved
With this change, the messagebar is used to show a message if the
export operation failed or succeeded.
@ptitjano
Copy link
Contributor Author

Fixed the issue introduced from the applied suggestion. A toString() call was missing.

@lbartoletti lbartoletti merged commit 8c4ffe5 into qgis:master Dec 18, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D Relates to QGIS' 3D engine or rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants