Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PEP440 versions for python plugins #60137

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

T4mmi
Copy link
Contributor

@T4mmi T4mmi commented Jan 14, 2025

Description

Python allows for 1.0a1 style version syntax instead of 1.0.alpha1 semver style.

This PR works with setuptools_scm syntax, but does not fixes every PEP440 syntaxes:

  • dev versions are trickier to treat (but we might ignore them since these versions should not be uploaded on repos)
  • mixing plain alpha/beta with shorthand a/b will missbehave 0.1alpha1 > 0.1a2 (but coventions should be consistent inside a project)

@github-actions github-actions bot added this to the 3.42.0 milestone Jan 14, 2025
Support alpha and beta version syntax from PEP440 for python plugins
see https://peps.python.org/pep-0440/
@T4mmi T4mmi force-pushed the Allow-PEP-versions-for-plugins branch from 50785de to 0b8652f Compare January 14, 2025 10:23
Copy link

github-actions bot commented Jan 14, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 0b8652f)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 0b8652f)

@m-kuhn m-kuhn merged commit 4334203 into qgis:master Jan 14, 2025
30 checks passed
@T4mmi T4mmi deleted the Allow-PEP-versions-for-plugins branch January 16, 2025 15:49
@T4mmi T4mmi mentioned this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants