fix: empty vector layer reload() will never invalidate cache #60154
Conversation
empty layer will never reload cache after the external program inserts the data
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
|
| mCacheOrderedKeys.clear(); | ||
| mCacheUnorderedKeys.clear(); | ||
| mFullCache = false; | ||
| emit invalidated(); |
There was a problem hiding this comment.
We can keep the if condition and just get out the signal firing
There was a problem hiding this comment.
To be honest I cant' remember exactly but I suspect that part of the speed optimization of my original PR was to not fire the signal when the cache was not changed (because it was already empty) .
The fact here is that there are possibly many side effects when firing a signal and some of these can slow down the application significantly.
I would recommend to explore if are there other ways to fix the issue.
There was a problem hiding this comment.
However, the condition only blocks the signal when it is empty, and the signal is still emitted when it is not empty. Is it feasible to add if(mFullCache)?
There was a problem hiding this comment.
@elpaso That would require then to be able to distinguish between an empty cache because of an empty layer, or an empty cache because cache has not been yet populated
empty layer will never reload cache after the external program inserts the data