Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 3d map tool to change point cloud attribute values #60172

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

uclaros
Copy link
Contributor

@uclaros uclaros commented Jan 16, 2025

Description

First tool to use the new point cloud editing API!
There's still no way to start editing on the point cloud layer other than python console, but should be soon fixed

Accessible via a new toolbar in 3d views, this tool enables selecting points and changing one of their attributes to a specified value:
Peek 2025-01-16 18-39

@github-actions github-actions bot added this to the 3.42.0 milestone Jan 16, 2025
@uclaros uclaros force-pushed the point-cloud-editing-3d-tool branch from 3686b66 to ea2e1e5 Compare January 16, 2025 16:50
Copy link

github-actions bot commented Jan 16, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit d665c3e)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit d665c3e)

Copy link
Member

@wonder-sk wonder-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

src/app/3d/qgs3dmaptoolpointcloudchangeattribute.cpp Outdated Show resolved Hide resolved
src/app/3d/qgs3dmapcanvaswidget.cpp Outdated Show resolved Hide resolved
@uclaros
Copy link
Contributor Author

uclaros commented Jan 16, 2025

Any reason why clang-tidy cannot find the mocs?
I've seen this in other PR too, is it safe to ignore?

@uclaros uclaros merged commit e728a52 into qgis:master Jan 17, 2025
30 of 31 checks passed
@uclaros uclaros deleted the point-cloud-editing-3d-tool branch January 17, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants