[vector layer] Fix newly-added features in the edit buffer prior to adding a new attribute will not save the new attribute's values #60226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dding a new attribute will not save the new attribute's values (fixes qgis#59783)
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nirvn
force-pushed
the
add_attribute_edit_value_fix
branch
from
8dfbd73 to
00843e9
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #59783 , a pretty serious data loss scenario with regards to the way the vector layer edit buffer handles newly added features followed by newly added attributes.
Basically, when adding a new feature via attribute table, the feature would come with a defined fields(), which would then become outdated when a newly-added attribute was added during the session. That meant that if a user would do the following:
1/ add a new feature
2/ add a new attribute
3/ edit the new attribute from the newly-added feature
4/ commit
The user would lose the data added in step 3.