Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for linting docs #1080

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Conversation

coruscating
Copy link
Collaborator

Summary

Added linting of Sphinx docs to the lint CI job with the tox environment docs-lint. The job will fail on broken references and links.

Details and comments

  • A new docs/lint/conf.py is added for this linting setting. It currently has a manual list of regex objects to ignore, because there are a lot of deprecated objects in the release notes that need to be manually updated or added to the ignore list.
  • The arxiv autolink in docstrings has been changed to the abstract instead of the PDF for user friendliness.
  • The docs are no longer incompatible with the newest sphinx-autodoc-typehints so the version pin from Pin sphinx-autodoc-typehints version #1017 has been removed. This closes Fix docs incompatibility with sphinx-autodoc-typehints #1018.
  • Actual format linting like sphinx-lint is not yet included.

coruscating and others added 8 commits March 14, 2023 18:10
also fixed broken links and bumped some package versions
renamed env to `docs-lint`, changed arxiv link to abstract instead of
pdf, and various other fixes
linux build is failing on the minimal conf so I'm adding more lines back
in. hard to debug locally because the mac build has a different set of
warnings.
this syncs up the names on the manuals page and the API experiments
page
@coruscating
Copy link
Collaborator Author

I'm having a hard time with the new tox -edocs-lint CI job. It runs all the way through on Mac (besides the known issue of many warnings). On Linux it's currently crashing early with
sphinx.errors.ExtensionError: Handler <function _get_versions at 0x7f4a4013c0d0> for event 'config-inited' threw an exception (exception: Command '['git', 'describe', '--abbrev=0']' returned non-zero exit status 128.)
and I'm not sure yet why that's happening just in this mode.

coruscating added a commit that referenced this pull request Mar 22, 2023
### Summary

This PR is essentially the documentation fixes from #1080 since the lint
CI pipeline needs more work.

### Details and comments

- The docs are no longer incompatible with the newest
sphinx-autodoc-typehints so the version pin from #1017 has been removed.
This closes #1018.
- Updates curve analysis tutorial to the newest version (#983 had
accidentally reverted to an older version)
- Changes arxiv autolinks from pdfs to abstract page to be more user
friendly
- Renames the new ExperimentData how-to to rerunning analysis and adds
additional info on using `add_data`
- Moved functions from `curve_analysis/data_processing.py` to `utils.py`
- Changes benchmarking experiments to verification experiments on the
manual page to match the library API page
- Added referenced classes and functions that weren't included in the
docs
- Various formatting fixes for passing Sphinx nitpick mode
@CLAassistant
Copy link

CLAassistant commented Jul 18, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix docs incompatibility with sphinx-autodoc-typehints
2 participants