-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace qiskit-terra references with qiskit references #1318
Changes from 8 commits
3eddcdd
4cd7b50
7a877ff
d77779a
12cc337
e0a17a2
35a8da8
f94166a
bc4dd22
e42b0be
6460bb6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# Numpy 1.25 deprecated some behaviours that we used, and caused some | ||
# tests to flake. See https://github.com/Qiskit/qiskit-terra/issues/10305, | ||
# tests to flake. See https://github.com/Qiskit/qiskit/issues/10305, | ||
# remove pin when resolving that. | ||
numpy<1.25 | ||
numpy<1.25 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- | ||
upgrade: | ||
- | | ||
The dependency on ``qiskit-terra`` was replaced with a dependency on | ||
``qiskit``. This change follows the move in upstream Qiskit to rename | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should the old and new version numbers be explicitly mentioned here too? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done but we need to keep this release note in mind if we merge #1288 and increase the minimum qiskit version. |
||
``qiskit-terra`` to ``qiskit``. For more information see `the Qiskit | ||
repository renaming plan | ||
<https://github.com/Qiskit/RFCs/blob/5793e78dc8e4d8d17f8ef7fad789c6c5ebd3a061/0011-repo-rename.md>`__ | ||
and the `Qiskit issue <https://github.com/Qiskit/qiskit/issues/11240>`__ | ||
for the renaming of the package. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
qiskit-terra>=0.45.0 | ||
qiskit>=0.45.0 | ||
black~=22.0 | ||
fixtures | ||
stestr | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not also return the Qiskit Experiments version like the previous code did in the
except
clause? I'm not quite sure what this function is meant for.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a little confused by this part. Qiskit is a required dependency, so we should be able to get its version without error and not need the except block, so I went with what the try block was doing to continue the existing behavior. I pushed a new commit to switch to the except block style of capturing qiskit and qiskit-experiments. I thought about capturing other packages (qiskit-ibm-experiment?) but I think these two make the most sense. qiskit changes could change transpilation and affect the circuits in something like RB. qiskit-experiments could change the circuits method or the analysis function. So it is good to capture both with the experiment metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, saving both makes sense and we probably should have been doing that earlier. We may have to change this to git commit IDs in the future but this is good for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good idea. I had been thinking about that. I have done it on other repos before.