Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernise Dactyl keyboard #21388

Open
wants to merge 44 commits into
base: develop
Choose a base branch
from
Open

Modernise Dactyl keyboard #21388

wants to merge 44 commits into from

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Jun 26, 2023 •
edited
Loading

Description

  • merged dactyl and dactyl_promicro as to modernise the Dactyl keyboard in general.
    • alias added for the moved
  • removed dactyl_rah due it being a matrix wiring alternative to dactyl_promicro

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 26, 2023
@dunk2k
additions/corrections:
c6483b0 
- readme.md's updated
- build failures for dactyl/legacy corrected
- conditionial audio pin added
@dunk2k dunk2k marked this pull request as ready for review June 26, 2023 20:40
@dunk2k dunk2k changed the title Modernise dactyl and dactyl_promicro Modernise Dactyl keyboard Jun 26, 2023
@drashna drashna requested a review from a team June 28, 2023 09:57
@github-actions github-actions bot added the dd Data Driven Changes label Sep 22, 2023
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Mar 13, 2024
@dunk2k
Copy link
Contributor Author

dunk2k commented Mar 13, 2024

Please label as awaiting review

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Mar 14, 2024
@dunk2k
Copy link
Contributor Author

dunk2k commented Jan 24, 2025

@drashna @fauxpark
Hi gents,
A quick once over, given length of time since prior approval, would be greatly appreciated 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@hughrawlinson hughrawlinson hughrawlinson approved these changes

Assignees
No one assigned
Labels
awaiting review dd Data Driven Changes keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dunk2k @hughrawlinson @drashna @fauxpark