RK #23559

sdk66 · 2024-04-19T03:37:21Z

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Added RK customer keyboard models

Remove redundant keyboards

github-actions · 2024-06-04T01:50:43Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

keyboards/rk/rk839/readme.md

keyboards/rk/rk839/info.json

tzarc · 2024-06-13T05:39:41Z

Move to Draft as no wireless code has been provided.

sdk66 · 2024-06-13T06:07:55Z

移至草稿，因为未提供无线代码。

First of all, I'm sorry, now the keyboard I use is a wired, the wireless circuit part on the PCB is not referenced, this keyboard is a pure wired keyboard, and there is no wireless part

sdk66 · 2024-06-13T06:13:04Z

移至草稿，因为未提供无线代码。

Now the modified PCB looks like this。I'm sorry for the inconvenience and thank you for your correction

tzarc · 2024-06-13T07:11:23Z

You'll have to forgive my reluctance to believe you, but 5 hours ago you posted a wireless keyboard PCB screenshot, and now, once told that you need to provide wireless sources, the wireless portion has magically disappeared.

As per the PR checklist:

Wireless-capable boards:

Given license abuse from vendors, QMK does not accept any vendor PRs for wireless- or Bluetooth-capable keyboards without wireless and/or Bluetooth code
- Historically, vendors have done this in bad faith in order to attain downstream VIA compatibility with no intention of releasing wireless sources
- QMK's license, the GPL2+, requires full source disclosure for any distributed binary -- including full sources for any keyboard shipped by vendors containing QMK and/or firmware-side VIA code
- If a vendor's wireless-capable keyboard PR submission is lacking wireless capability, then the PR will be left on-hold and unmergeable until wireless bindings are provided
- If a vendor's wireless-capable keyboard is merged into QMK before it's known that the board is wireless, then all existing and future PRs from the same vendor will be put on hold until wireless bindings for the offending keyboard are provided

So, with that in mind, once released is this a wired-only, or wireless keyboard?

keyboards/rk/rk839/info.json

tzarc · 2024-06-13T07:14:49Z

keyboards/rk/rk839/rk839.c

+    gpio_set_pin_output(A5);
+    gpio_write_pin_high(A5);


Please explain the purpose of A5.

Please explain the purpose of A5.
Now this A5 pin is used to control the switch of the LED light

tzarc · 2024-06-13T07:15:14Z

keyboards/rk/rk839/info.json

This file should be named keyboard.json.

Thank you for your advice

keyboards/rk/rk839/rules.mk

dunk2k · 2024-06-13T07:15:27Z

keyboards/rk/rk839/info.json

+                {"matrix": [0, 11], "x": 11, "y": 0},
+                {"matrix": [0, 12], "x": 12, "y": 0},
+                {"matrix": [0, 13], "x": 13, "y": 0, "w": 2},
+                {"matrix": [0, 14], "x": 15, "y": 0},


Looking at references/images provided, this key doesn't exist. Can this line, of code, be removed to match references?

Thanks for the suggestion, I tried to remove the extra keystrokes

Suggested change

{"matrix": [0, 14], "x": 15, "y": 0},

Do you need to delete this line?

Do you need to delete this line?

Yes please, as this key doesn't exist in the images you've shared

Thanks for the suggestion, I'll delete this line

是否需要删除此行？

是的，因为此键在您共享的图像中不存在

Thanks for the suggestion, I'll delete this line

sdk66 · 2024-06-13T07:27:57Z

你必须原谅我不愿意相信你，但 5 小时前你发布了无线键盘 PCB 截图，现在，一旦被告知你需要提供无线源，无线部分就神奇地消失了。

根据 PR 清单：

支持无线的板：

鉴于供应商滥用许可证，QMK 不接受任何没有无线和/或蓝牙代码的无线或蓝牙键盘的供应商 PR

从历史上看，供应商这样做是出于恶意，以实现下游VIA兼容性，而无意发布无线源

QMK 的许可证 GPL2+ 要求对任何分布式二进制文件进行完整的源代码披露——包括供应商提供的任何包含 QMK 和/或固件端 VIA 代码的键盘的完整源代码

如果供应商的无线键盘 PR 提交缺少无线功能，则 PR 将处于暂停状态且不可合并，直到提供无线绑定

如果供应商的无线键盘在知道主板是无线的之前合并到 QMK 中，则同一供应商的所有现有和未来 PR 都将被搁置，直到为有问题的键盘提供无线绑定

因此，考虑到这一点，一旦发布，这是纯有线键盘还是无线键盘？

This is a pure wired keyboard,There won't be any wireless functionality.,

dunk2k · 2024-06-13T07:34:10Z

keyboards/rk/rk839/info.json

+                {"matrix": [0, 11], "x": 11, "y": 0},
+                {"matrix": [0, 12], "x": 12, "y": 0},
+                {"matrix": [0, 13], "x": 13, "y": 0, "w": 2},
+                {"matrix": [0, 14], "x": 15, "y": 0},


Suggested change

{"matrix": [0, 14], "x": 15, "y": 0},

dunk2k · 2024-06-13T07:34:40Z

keyboards/rk/rk839/info.json

+                {"matrix": [1, 11], "x": 11.5, "y": 1},
+                {"matrix": [1, 12], "x": 12.5, "y": 1},
+                {"matrix": [1, 13], "x": 13.5, "y": 1, "w": 1.5},
+                {"matrix": [1, 14], "x": 15, "y": 1.25},


Suggested change

{"matrix": [1, 14], "x": 15, "y": 1.25},

{"matrix": [1, 14], "x": 15, "y": 1},

1.修改info.json的名字为keyboard.json 2.删除rules.mk文件 3.删除keyboard.json的169行

dunk2k

removed keycode from non-existent key position; fixes CI Build failure

dunk2k · 2024-06-13T09:21:42Z

keyboards/rk/rk839/keymaps/default/keymap.c

+const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
+
+    [0] = LAYOUT( /* Base */
+        KC_ESC,   KC_1,       KC_2,       KC_3,     KC_4,     KC_5,     KC_6,     KC_7,     KC_8,     KC_9,     KC_0,       KC_MINS,  KC_EQL,   KC_BSPC,   KC_MUTE,


Suggested change

KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC, KC_MUTE,

KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC,

I think that KC_MUTE should be there. At least on my keyboard it is there

dunk2k · 2024-06-13T09:21:52Z

keyboards/rk/rk839/keymaps/via/keymap.c

+const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
+
+    [0] = LAYOUT( /* Base */
+        KC_ESC,   KC_1,       KC_2,       KC_3,     KC_4,     KC_5,     KC_6,     KC_7,     KC_8,     KC_9,     KC_0,       KC_MINS,  KC_EQL,   KC_BSPC,   KC_MUTE,


Suggested change

KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC, KC_MUTE,

KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC,

keyboards/rk/rk839/rk839.c

修改格式，使用宏

sdk66 · 2024-07-09T02:22:20Z

We currently have two firmware versions: one is the QMK wired firmware, and the other is our self-developed tri-mode firmware. We do not know how to develop a QMK tri-mode keyboard. This keyboard uses the QMK firmware for wired functionality and does not have wireless capabilities. The wireless functionality is provided by a separately developed firmware that is not based on QMK。I apologize for any confusion caused and wish you a pleasant life。

tzarc · 2024-07-09T09:06:09Z

Does the tri-mode support VIA?

sdk66 · 2024-07-09T09:10:20Z

Does the tri-mode support VIA?

Of course, it is not supported. The current keyboard uses wired QMK firmware, and the tri-mode solution is not supported.

tzarc · 2024-07-10T07:51:25Z

This PR is on hold until #24085 is rectified.

tzarc · 2024-08-26T10:36:50Z

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

sdk66 added 3 commits April 12, 2024 10:45

First commit

0860ba0

Merge branch 'master' of https://github.com/sdk66/qmk_firmware

ee43abe

675571

29bd290

Added RK customer keyboard models

github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 19, 2024

736566

3a2ef9a

Remove redundant keyboards

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 4, 2024

dunk2k suggested changes Jun 12, 2024

View reviewed changes

keyboards/rk/rk839/readme.md Outdated Show resolved Hide resolved

keyboards/rk/rk839/info.json Outdated Show resolved Hide resolved

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jun 13, 2024

tzarc added invalid crippled-firmware labels Jun 13, 2024

tzarc marked this pull request as draft June 13, 2024 05:39

dunk2k suggested changes Jun 13, 2024

View reviewed changes

keyboards/rk/rk839/info.json Outdated Show resolved Hide resolved

tzarc reviewed Jun 13, 2024

View reviewed changes

keyboards/rk/rk839/rules.mk Outdated Show resolved Hide resolved

dunk2k suggested changes Jun 13, 2024

View reviewed changes

修改要求

8a4937d

1.修改info.json的名字为keyboard.json 2.删除rules.mk文件 3.删除keyboard.json的169行

dunk2k suggested changes Jun 13, 2024

View reviewed changes

恢复为原来的

f5d5ade

tzarc mentioned this pull request Jun 13, 2024

add rk839 keyboard #23572

Closed

14 tasks

tzarc reviewed Jun 13, 2024

View reviewed changes

keyboards/rk/rk839/rk839.c Outdated Show resolved Hide resolved

sdk66 added 3 commits June 14, 2024 09:11

updata rk839.c

368ddec

修改格式，使用宏

更新

27b48fd

更新

2f22ef9

tzarc mentioned this pull request Jul 10, 2024

Manufacturers distributing without source code -- wireless tri-mode boards, missing functionality such as HE matrix etc. #24085

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RK #23559

RK #23559

sdk66 commented Apr 19, 2024 •

edited

Loading

github-actions bot commented Jun 4, 2024

tzarc commented Jun 13, 2024

sdk66 commented Jun 13, 2024

sdk66 commented Jun 13, 2024

tzarc commented Jun 13, 2024

tzarc Jun 13, 2024

sdk66 Jun 13, 2024

tzarc Jun 13, 2024

sdk66 Jun 13, 2024

dunk2k Jun 13, 2024 •

edited

Loading

sdk66 Jun 13, 2024

dunk2k Jun 13, 2024

sdk66 Jun 13, 2024

dunk2k Jun 13, 2024

sdk66 Jun 13, 2024

sdk66 commented Jun 13, 2024

dunk2k Jun 13, 2024

dunk2k Jun 13, 2024

dunk2k left a comment •

edited

Loading

dunk2k Jun 13, 2024

iamdanielv Aug 30, 2024

dunk2k Jun 13, 2024

sdk66 commented Jul 9, 2024

tzarc commented Jul 9, 2024

sdk66 commented Jul 9, 2024

tzarc commented Jul 10, 2024

tzarc commented Aug 26, 2024

	{"matrix": [1, 14], "x": 15, "y": 1.25},
	{"matrix": [1, 14], "x": 15, "y": 1},

	KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC, KC_MUTE,
	KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC,

RK #23559

Are you sure you want to change the base?

RK #23559

Conversation

sdk66 commented Apr 19, 2024 • edited Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

github-actions bot commented Jun 4, 2024

tzarc commented Jun 13, 2024

sdk66 commented Jun 13, 2024

sdk66 commented Jun 13, 2024

tzarc commented Jun 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dunk2k Jun 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sdk66 commented Jun 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dunk2k left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sdk66 commented Jul 9, 2024

tzarc commented Jul 9, 2024

sdk66 commented Jul 9, 2024

tzarc commented Jul 10, 2024

tzarc commented Aug 26, 2024

sdk66 commented Apr 19, 2024 •

edited

Loading

dunk2k Jun 13, 2024 •

edited

Loading

dunk2k left a comment •

edited

Loading