Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flash wear leveling sector calculation #24776

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix flash wear leveling sector calculation #24776

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f0b5d3
Fix flash wear leveling sector calculation
Diff-fusion Jan 2, 2025
d0002d3
Review changes
Diff-fusion Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions platforms/chibios/drivers/wear_leveling/wear_leveling_efl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,23 @@ bool backing_store_init(void) {
#else // defined(WEAR_LEVELING_EFL_FIRST_SECTOR)

// Work out how many sectors we want to use, working backwards from the end of the flash
flash_sector_t last_sector = desc->sectors_count - WEAR_LEVELING_EFL_OMIT_LAST_SECTOR_COUNT;
flash_sector_t last_sector = desc->sectors_count;

// skip sectors that are past the actual flash size
while (flashGetSectorOffset(flash, last_sector - 1) >= flash_size) {
if (--last_sector == 0) {
chSysHalt("No sector in available flash range");
}
}

if (WEAR_LEVELING_EFL_OMIT_LAST_SECTOR_COUNT >= last_sector) {
chSysHalt("Last sector intended to be used with wear_leveling is beyond available flash descriptor range");
}

last_sector -= WEAR_LEVELING_EFL_OMIT_LAST_SECTOR_COUNT;

for (flash_sector_t i = 0; i < last_sector; ++i) {
first_sector = last_sector - i - 1;
if (flashGetSectorOffset(flash, first_sector) >= flash_size) {
last_sector = first_sector;
continue;
}
counter += flashGetSectorSize(flash, first_sector);
if (counter >= (WEAR_LEVELING_BACKING_SIZE)) {
sector_count = last_sector - first_sector;
Expand All @@ -98,6 +108,10 @@ bool backing_store_init(void) {
}
}

if (counter < WEAR_LEVELING_BACKING_SIZE) {
chSysHalt("Not enough flash is available for the requested wear_leveling size");
}

#endif // defined(WEAR_LEVELING_EFL_FIRST_SECTOR)

return true;
Expand Down
Loading