Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keyboard.json #24778

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update keyboard.json #24778

wants to merge 4 commits into from

Conversation

iliorik
Copy link
Contributor

@iliorik iliorik commented Jan 2, 2025

change button coordinates on right half

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

change button coordinates on right half
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this may fix the display issues, the order still does not match that expected by the keymap. The whole right hand is mostly reversed, with the thumb clusters being quite out of order.

The fact its so wrong suggests this and the previous submittion has not actually been tested on hardware.

@iliorik
Copy link
Contributor Author

iliorik commented Jan 3, 2025

I'm already typing on this keyboard.
Ok. I will fix it.

change coordinates on right half
@iliorik iliorik requested a review from zvecr January 3, 2025 06:42
@zvecr
Copy link
Member

zvecr commented Jan 3, 2025

image
Still incorrect. You can validate this by previewing on https://config.qmk.fm, by using ctrl+shift+i to load the keyboard.json and enabling "fast input" in settings menu.

@iliorik
Copy link
Contributor Author

iliorik commented Jan 3, 2025

shot-2025-01-03_23-58-41
if I usе ctrl+shift+i to load the keyboard.json, I get this message. What am I doing wrong?

@sigprof
Copy link
Contributor

sigprof commented Jan 3, 2025

You have a trailing comma: "mousekey": true, — this is not allowed in JSON. QMK build scripts read the keyboard.json files as Hjson, which allows trailing commas and some other extensions, but config.qmk.fm needs pure JSON.

@iliorik
Copy link
Contributor Author

iliorik commented Jan 4, 2025

I've fixed the layout. i think all ok. (my keyboard config: https://github.com/iliorik/qmk_configurator/blob/master/public/keymaps/h/handwired_dactyl_manuform_5x8_default.json)
shot-2025-01-04_14-31-07
shot-2025-01-04_14-31-37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants