-
-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update keyboard.json #24778
base: master
Are you sure you want to change the base?
Update keyboard.json #24778
Conversation
change button coordinates on right half
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this may fix the display issues, the order still does not match that expected by the keymap. The whole right hand is mostly reversed, with the thumb clusters being quite out of order.
The fact its so wrong suggests this and the previous submittion has not actually been tested on hardware.
I'm already typing on this keyboard. |
change coordinates on right half
|
You have a trailing comma: |
I've fixed the layout. i think all ok. (my keyboard config: https://github.com/iliorik/qmk_configurator/blob/master/public/keymaps/h/handwired_dactyl_manuform_5x8_default.json) |
change button coordinates on right half
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist