Add more layout for skiller_sgk50_s4 #24784
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If review is OK, please merge as soon as possible, thanks. |
drashna
reviewed
Jan 4, 2025
| @@ -21,7 +21,7 @@ | |||
| "rgb_matrix": true | |||
| }, | |||
| "matrix_pins": { | |||
| "cols": ["C0", "C1", "C2", "C3", "A6", "B1", "B10", "B11", "B12", "B13", "B14", "B15", "C6", "C7"], | |||
| "cols": ["C0", "C1", "C2", "C3", "A6", "B1", "B10", "B11", "B12", "B13", "B14", "C6", "C7", "C8", "C9", "A8"], | |||
There was a problem hiding this comment.
This appears to be a significant change (B15 is dropped, and 3 additional pins added)
| "pid": "0x1020", | ||
| "suspend_wakeup_delay": 1000, | ||
| "vid": "0x6332" | ||
| }, | ||
| "ws2812": { | ||
| "pin": "A8" | ||
| "pin": "B15" |
There was a problem hiding this comment.
If this is a new hardware revision, it should be added as a new revision rather than config changes.
There was a problem hiding this comment.
The previous version was likely not released to users, so this modification falls under the same version.
There was a problem hiding this comment.
@drashna Can you continue the review? Or do you need me to do something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add more layout for skiller_sgk50_s4
Types of Changes
Issues Fixed or Closed by This PR
Checklist