Chew folders #24785
Open
Chew folders #24785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
requested changes
Jan 7, 2025
| @@ -19,7 +8,6 @@ | |||
| ["GP7", "GP6", "GP5", "NO_PIN", "NO_PIN"] | |||
| ] | |||
| }, | |||
| "processor": "RP2040", | |||
| "split": { | |||
| "enabled": true, | |||
| "matrix_pins": { | |||
There was a problem hiding this comment.
The previous submission used EE_HANDS, is there now a new PCB revision that supports handedness by pin?
Suggested change
| "matrix_pins": { | |
| "handedness": { | |
| "pin": "GP10" | |
| }, | |
| "matrix_pins": { |
There was a problem hiding this comment.
Yes, gp10 on the left and gp12 on the right are on +vcc.
Thanks to that I can use these pins as a kind of vbus.
(There were the last free pins thanks to the uart half-duplex)
There was a problem hiding this comment.
Humm, now I have some doubts about that.
We could eventually remove this option to leave the user free to decide in the keymap config.
In this case I will be able to use the full duplex with a potential next PCB 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello,
That PR is an attempt to validate the
Add Chew mono #23835which had conflicts.So it reorganize the chew folder with two subfolders.
Types of Changes
Issues Fixed or Closed by This PR
Checklist