Adding ability to use more than one Cirque Pinnacle via SPI

[haxwagon]

There is now a callback to get the current SPI CS pin when operations are being used. Implement cirque_pinnacle_spi_get_cs_pin to set the pin to be used. If this function is not implemented, the weak method will use the legacy method of CIRQUE_PINNACLE_SPI_CS_PIN.

Description

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• [-] I have added tests to cover my changes.
• [-] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[drashna]

Long term, I think that #20374 is the end goal here.

That said, this code is .... messy at best, and is likely to cause issues (eg, selecting the wrong device, if you're not careful).

[haxwagon]

Yikes! "messy at best"? It's three lines and is also how SPI is designed to work. The default implementation is for backwards compatibility.

This supports non pointing device usages of the devices... which is how I use them. I'm fine if you want to close this PR. These changes were the smallest changes I could make and still get my work done.

[drashna]

To be clear, the implementation itself isn't what I meant by messy, but rather the functionality.

From what I'm guessing, you'd be scanning the second cirque by replacing the cs pin function and switch between the main and secondary pads, correct?

If so, I'm really, really not a fan of this. The way that the pmw33xx multiple sensor support may be a better way to handle this, IMO.

But I'm not sure on which is the best method forward, though.

[zvecr]

I would agree the consuming usage would appear be quite fragile, but will defer to others with more domain knowledge in this area.

However, the following suggestion should at least make it pass the failing CI checks.

[zvecr]

Suggested change

	__attribute__((weak)) uint8_t cirque_pinnacle_spi_get_cs_pin(void) { return CIRQUE_PINNACLE_SPI_CS_PIN; }
	__attribute__((weak)) pin_t cirque_pinnacle_spi_get_cs_pin(void) {
	return CIRQUE_PINNACLE_SPI_CS_PIN;
	}