[keyboard] mzmkb/slimdash/rev1 #24804
Open
+452
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested changes
Jan 9, 2025
| #define SERIAL_USART_RX_PIN GP18 // USART RX pin | ||
| #define SERIAL_PIO_USE_PIO1 // Use PIO1 as PIO0 is used for WS2812 driver | ||
|
|
||
| #define MASTER_LEFT // USB-C connects to left half of keyboard |
There was a problem hiding this comment.
This is the default behavior and doesn't need to be defined
Suggested change
| #define MASTER_LEFT // USB-C connects to left half of keyboard |
Comment on lines
+5
to
+15
| "audio": false, | ||
| "backlight": false, | ||
| "bootmagic": false, | ||
| "command": false, | ||
| "console": false, | ||
| "extrakey": true, | ||
| "key_lock": false, | ||
| "mousekey": true, | ||
| "nkro": true, | ||
| "rgb_matrix": true, | ||
| "rgblight": false |
There was a problem hiding this comment.
Suggested change
| "audio": false, | |
| "backlight": false, | |
| "bootmagic": false, | |
| "command": false, | |
| "console": false, | |
| "extrakey": true, | |
| "key_lock": false, | |
| "mousekey": true, | |
| "nkro": true, | |
| "rgb_matrix": true, | |
| "rgblight": false | |
| "extrakey": true, | |
| "mousekey": true, | |
| "nkro": true, | |
| "rgb_matrix": true, |
Comment on lines
+175
to
+176
| "layouts": { | ||
| "LAYOUT": { |
There was a problem hiding this comment.
Since this looks to use a 5x14 ortho layout
Suggested change
| "layouts": { | |
| "LAYOUT": { | |
| "community_layouts": [ "ortho_5x14" ], | |
| "layouts": { | |
| "LAYOUT_ortho_5x14": { |
| * | RM_DN| RM_UP| GAMEM| GUI | Lower| Space| LSFT | | RCTL | Enter| Raise| HOME | END |PageUp|PageDn| | ||
| * ,----------------------------------------------------------------------------------------------------------------------. | ||
| */ | ||
| [_QWERTY] = LAYOUT( |
There was a problem hiding this comment.
Suggested change
| [_QWERTY] = LAYOUT( | |
| [_QWERTY] = LAYOUT_ortho_5x14( |
| * | | | | NOOP | | | | | | | | ← | ↓ | ↑ | → | | ||
| * ,----------------------------------------------------------------------------------------------------------------------. | ||
| */ | ||
| [_GAMEMODE] = LAYOUT( |
There was a problem hiding this comment.
Suggested change
| [_GAMEMODE] = LAYOUT( | |
| [_GAMEMODE] = LAYOUT_ortho_5x14( |
| * | | | | | | | | | | PENT | | 0 | . | | | | ||
| * ,----------------------------------------------------------------------------------------------------------------------. | ||
| */ | ||
| [_LOWER] = LAYOUT( |
There was a problem hiding this comment.
Suggested change
| [_LOWER] = LAYOUT( | |
| [_LOWER] = LAYOUT_ortho_5x14( |
| * | | | | | | | | | | | | | | | | | ||
| * ,----------------------------------------------------------------------------------------------------------------------. | ||
| */ | ||
| [_RAISE] = LAYOUT( |
There was a problem hiding this comment.
Suggested change
| [_RAISE] = LAYOUT( | |
| [_RAISE] = LAYOUT_ortho_5x14( |
waffle87
requested changes
Jan 9, 2025
| "split_count": [35, 35] | ||
| }, | ||
| "split": { | ||
| "enabled": true, |
There was a problem hiding this comment.
Already enabled at the top level.
Suggested change
| "enabled": true, |
| "driver": "vendor" | ||
| }, | ||
| "transport": { | ||
| "protocol": "serial", |
There was a problem hiding this comment.
Default behaviour.
Suggested change
| "protocol": "serial", |
Comment on lines
+161
to
+164
| }, | ||
| "usb_detect": { | ||
| "enabled": true | ||
| } |
There was a problem hiding this comment.
Default behaviour.
Suggested change
| }, | |
| "usb_detect": { | |
| "enabled": true | |
| } | |
| } |
| @@ -0,0 +1,43 @@ | |||
| # mzmkb/slimdash/rev1 | |||
There was a problem hiding this comment.
Suggested change
| # mzmkb/slimdash/rev1 | |
| # Slimdash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add mzmkb/slimdash keyboard to QMK
Types of Changes
Issues Fixed or Closed by This PR
Checklist