-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding a function to qdac2 driver #215
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from a few typos and need to remove the checkpoints folder.
I forgot to put it in the process but we need to run black to format all the files before the PR otherwise it will fail :)
Configure a QDAC2 channel to play a specicif voltage, using pyvisa commands. | ||
|
||
:param qdac: the QDAC2 object. | ||
:param channel: the QDAC2 channel that will output the voltage from the voltage list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The voltage doesn't come from the voltage list here, but from the specified value
|
||
:param qdac: the QDAC2 object. | ||
:param channel: the QDAC2 channel that will output the voltage from the voltage list. | ||
:param voltage: the desired voltage to output from the QDAC channel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specify the unit as well
|
||
:param qdac: the QDAC2 object. | ||
:param channel: the QDAC2 channel that will output the voltage from the voltage list. | ||
:param voltage: the desired voltage to output from the QDAC channel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specify the unit as well
Configure a QDAC2 channel to play a specicif voltage, using pyvisa commands. | ||
|
||
:param qdac: the QDAC2 object. | ||
:param channel: the QDAC2 channel that will output the voltage from the voltage list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The voltage doesn't come from the voltage list here, but from the specified value
@@ -0,0 +1,477 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want the folder .ipynb_checkpoints here
@@ -0,0 +1,24 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want the folder .ipynb_checkpoints here
@@ -0,0 +1,527 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want the folder .ipynb_checkpoints here
" :param channel: the QDAC2 channel that will output the voltage from the voltage list.\n", | ||
" :param voltage: the desired voltage to output from the QDAC channel.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as above about the voltage list and unit
"metadata": {}, | ||
"source": [ | ||
"## Example:\n", | ||
"1. Setting the QDAC on a specific voltage - in the sexample you can set the QDAC on a specific, fixed, value. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example instead of sexample
maybe: "1. Setting the QDAC to output a specific constant voltage."
"set_QDAC_voltage(\n", | ||
" qdac,\n", | ||
" channel=1,\n", | ||
" voltage=0.0,\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will maybe be more readable in one line:
set_QDAC_voltage(qdac, channel=1, voltage=0.235)
adding a function to qdac2 driver. I added it to Tutorials and to the QD folder.