Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a function to qdac2 driver #215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MichalGQM
Copy link
Contributor

adding a function to qdac2 driver. I added it to Tutorials and to the QD folder.

@MichalGQM MichalGQM self-assigned this Jan 22, 2024
Copy link
Collaborator

@TheoLaudatQM TheoLaudatQM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a few typos and need to remove the checkpoints folder.
I forgot to put it in the process but we need to run black to format all the files before the PR otherwise it will fail :)

Configure a QDAC2 channel to play a specicif voltage, using pyvisa commands.

:param qdac: the QDAC2 object.
:param channel: the QDAC2 channel that will output the voltage from the voltage list.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The voltage doesn't come from the voltage list here, but from the specified value


:param qdac: the QDAC2 object.
:param channel: the QDAC2 channel that will output the voltage from the voltage list.
:param voltage: the desired voltage to output from the QDAC channel.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify the unit as well


:param qdac: the QDAC2 object.
:param channel: the QDAC2 channel that will output the voltage from the voltage list.
:param voltage: the desired voltage to output from the QDAC channel.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify the unit as well

Configure a QDAC2 channel to play a specicif voltage, using pyvisa commands.

:param qdac: the QDAC2 object.
:param channel: the QDAC2 channel that will output the voltage from the voltage list.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The voltage doesn't come from the voltage list here, but from the specified value

@@ -0,0 +1,477 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want the folder .ipynb_checkpoints here

@@ -0,0 +1,24 @@
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want the folder .ipynb_checkpoints here

@@ -0,0 +1,527 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want the folder .ipynb_checkpoints here

Comment on lines +150 to +151
" :param channel: the QDAC2 channel that will output the voltage from the voltage list.\n",
" :param voltage: the desired voltage to output from the QDAC channel.\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as above about the voltage list and unit

"metadata": {},
"source": [
"## Example:\n",
"1. Setting the QDAC on a specific voltage - in the sexample you can set the QDAC on a specific, fixed, value. "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example instead of sexample
maybe: "1. Setting the QDAC to output a specific constant voltage."

Comment on lines +491 to +494
"set_QDAC_voltage(\n",
" qdac,\n",
" channel=1,\n",
" voltage=0.0,\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will maybe be more readable in one line:
set_QDAC_voltage(qdac, channel=1, voltage=0.235)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants