Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several tests from WS-Trust and Santuario XML Security are failing on FIPS machine #1359

Merged
merged 1 commit into from
May 6, 2024

Conversation

JiriOndrusek
Copy link
Contributor

fixes #1358

this.getClass().getClassLoader().getResource("servicestore.jks").openStream(),
"sspass".toCharArray());
this.getClass().getClassLoader().getResource("myservice-keystore.jks").openStream(),
"myservice-keystore-password".toCharArray());

Check failure

Code scanning / CodeQL

Hard-coded credential in API call Critical

Hard-coded value flows to
sensitive API call
.
@@ -86,8 +86,8 @@
@POST
@Path("/{encryption}/decrypt")
public byte[] decrypt(byte[] encrypted, @PathParam("encryption") Encryption encryption) throws Exception {
Key privateKey = keyStore.getKey("myservicekey", "skpass".toCharArray());
return encryption.decrypt(encrypted, "http://www.w3.org/2001/04/xmlenc#aes128-cbc", privateKey);
Key privateKey = keyStore.getKey("myservice", "myservice-keystore-password".toCharArray());

Check failure

Code scanning / CodeQL

Hard-coded credential in API call Critical

Hard-coded value flows to
sensitive API call
.
X509Certificate cert = (X509Certificate) keyStore.getCertificate("myclientkey");
this.getClass().getClassLoader().getResource("myclient-keystore.jks").openStream(),
"myclient-keystore-password".toCharArray());
Key key = keyStore.getKey("myclient", "myclient-keystore-password".toCharArray());

Check failure

Code scanning / CodeQL

Hard-coded credential in API call Critical

Hard-coded value flows to
sensitive API call
.
Key key = keyStore.getKey("myclientkey", "ckpass".toCharArray());
X509Certificate cert = (X509Certificate) keyStore.getCertificate("myclientkey");
this.getClass().getClassLoader().getResource("myclient-keystore.jks").openStream(),
"myclient-keystore-password".toCharArray());

Check failure

Code scanning / CodeQL

Hard-coded credential in API call Critical

Hard-coded value flows to
sensitive API call
.
"cspass".toCharArray());
X509Certificate cert = (X509Certificate) keyStore.getCertificate("myclientkey");
this.getClass().getClassLoader().getResource("myclient-keystore.jks").openStream(),
"myclient-keystore-password".toCharArray());

Check failure

Code scanning / CodeQL

Hard-coded credential in API call Critical

Hard-coded value flows to
sensitive API call
.
Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JiriOndrusek

@ppalaga ppalaga merged commit 3deaedf into quarkiverse:main May 6, 2024
23 of 24 checks passed
@JiriOndrusek
Copy link
Contributor Author

@ppalaga I added backport to 3.8 labe; as I think that this PR should be backorted. I'll prepare a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several tests from WS-Trust and Santuario XML Security are failing on FIPS machine
2 participants