Feature/firebase experiments #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt webframeworks)
- Switched around the ordering of commands to avoid permission denied issues at filesystem level.
|
@loicmathieu There is also some workaround code in this PR for a bug I ran into (which mostly triggers when using the experiments, hence I added it to this PR). Filed a bug (#732) to remove the logic once the upstream bug is fixed. |
…mmands can run when the dev service is shutdown.
|
@loicmathieu Have some time to get this merged? Besides the feature, this PR also contains a few fixes for issues I ran in to while working with the extension quite a bit (i.e. really ironing out the corner cases). Can split the PR into multiple if that eases reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firebase has a way to enable experimental features. This is used e.g. when combining next.js with Firebase. The new option allows these experiments to be used.