Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigDecimal value fix in enums (#715) #720

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

Shohou
Copy link

@Shohou Shohou commented May 16, 2024

a fix for issue #715. It works and test passes, but please check my small changes as I didn't work with Qute before and maybe there is a better solution

@hbelmiro hbelmiro requested a review from ricardozanini May 16, 2024 11:46
@hbelmiro hbelmiro linked an issue May 16, 2024 that may be closed by this pull request
@hbelmiro hbelmiro self-requested a review May 16, 2024 11:55
@ricardozanini ricardozanini requested a review from fjtirado May 16, 2024 13:23
@ricardozanini
Copy link
Member

@fjtirado can you take a look since you introduced this fix?

Copy link
Contributor

@ricardozanini @hbelmiro This is being labeled as Stale.

@github-actions github-actions bot added the Stale label Jul 16, 2024
@hbelmiro hbelmiro removed the Stale label Jul 16, 2024
@hbelmiro
Copy link
Contributor

@fjtirado are you willing to review this PR? Otherwise I'll merge it.

@fjtirado
Copy link
Contributor

@hbelmiro @Shohou I think eq e.dataType "BigInteger" should be replaced by e.isNumeric

@Shohou
Copy link
Author

Shohou commented Jul 19, 2024

@fjtirado done

@fjtirado fjtirado merged commit 183fe3f into quarkiverse:main Aug 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

number enums generate non-compiling code
4 participants