Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Updated issues template #726

Conversation

gmalheiro
Copy link
Contributor

@gmalheiro gmalheiro commented May 27, 2024

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket

Issue description:

Updated the issue template to improve issue categorization and handling by adding specific fields and clarifications. This update ensures that all necessary information is captured right at the start, aiding in more efficient issue resolution.

Fixes #677

Copy link
Contributor

github-actions bot commented May 27, 2024

🎊 PR Preview e51dc0d has been successfully built and deployed. See the documentation preview: https://quarkus-openapi-generator-preview-pr-726.surge.sh

about: This template standardizes issue reporting within the project.
title: "[Issue]"
labels: bug, documentation, duplicate, enhancement, good first issue, help wanted,
invalid, question, wontfix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I open an issue, all these labels are added? I think we should rethink this. The labels will be added based on the checkbox in the Extension section. And for that, we will have to create a bot. 😅

Unless there's an option for users to pick the area once open an issue here. For example, the flow can be something like: Open an Issue, Pick from server, client, or general. So then GH can assign the correct labels.

@gmalheiro
Copy link
Contributor Author

@ricardozanini I've removed the lines you requested. Thanks for the feedback! Could you please confirm if everything is as expected?

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assignee is still there @gmalheiro.

Copy link
Member

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @gmalheiro!

I left some suggestions!

gmalheiro and others added 4 commits May 31, 2024 18:39
Co-authored-by: Matheus Cruz <56329339+mcruzdev@users.noreply.github.com>
Co-authored-by: Matheus Cruz <56329339+mcruzdev@users.noreply.github.com>
@gmalheiro
Copy link
Contributor Author

@mcruzdev Thanks for the suggestions! I accepted them!

@hbelmiro I removed the assignees section! Thanks for the feedback.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gmalheiro.

@mcruzdev
Copy link
Member

mcruzdev commented Jun 1, 2024

Thank you @gmalheiro, could you squash the commits?

gmalheiro and others added 2 commits June 1, 2024 20:46
* Updated issues template removed lines discussed in issue 726
* Removed assignees and followed Matheus Cruz @mcruzdev suggestions
@gmalheiro
Copy link
Contributor Author

@mcruzdev Done! Thanks for the support! 😁

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By adding a comment to the descriptions, we hide this information in the rendered issue.

gmalheiro and others added 3 commits June 3, 2024 20:43
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
@gmalheiro
Copy link
Contributor Author

@ricardozanini Tks for the suggestions! I accepted it!

@hbelmiro hbelmiro self-requested a review June 4, 2024 12:31
@gmalheiro gmalheiro requested a review from mcruzdev June 9, 2024 02:35
Copy link
Member

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hbelmiro
Copy link
Contributor

hbelmiro commented Aug 9, 2024

@all-contributors add @gmalheiro for docs.

Copy link
Contributor

@hbelmiro

I've put up a pull request to add @gmalheiro! 🎉

@hbelmiro hbelmiro merged commit 24106c3 into quarkiverse:main Aug 9, 2024
10 checks passed
FelixScherzinger pushed a commit to FelixScherzinger/quarkus-openapi-generator that referenced this pull request Sep 18, 2024
* Updated issues template

* feat: updated issue template remove lines discussed in issue 726

* Update .github/ISSUE_TEMPLATE/-issue-number---problem-description-.md

Co-authored-by: Matheus Cruz <56329339+mcruzdev@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/-issue-number---problem-description-.md

Co-authored-by: Matheus Cruz <56329339+mcruzdev@users.noreply.github.com>

* feat: removed assignees

* feat: added comma

* feat: Updated issues template and squashed commits
* Updated issues template removed lines discussed in issue 726
* Removed assignees and followed Matheus Cruz @mcruzdev suggestions

* Update .github/ISSUE_TEMPLATE/-issue-number---problem-description-.md

Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/-issue-number---problem-description-.md

Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/-issue-number---problem-description-.md

Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>

* Commented instruction

---------

Co-authored-by: Gabriel Malheiro <g.silva.malheiro@avanade.com>
Co-authored-by: Matheus Cruz <56329339+mcruzdev@users.noreply.github.com>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the issues template to help users identify which extension they are using
5 participants