Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main-lts] Added so equals and hashcode is generated in models. #924

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport: #920

Note: CI is not automatically triggered on backported PRs, please comment 'ok to test' to launch Jenkins jobs

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket

I have added so equals and hashCode is generated to the models. It's possible to disabled it if someone doesn't want it.

@ricardozanini I created an new branch and pull request, it was easier and faster for me to do that.

The result looks like this:

    @Override
    public boolean equals(Object o) {
        if (this == o) return true;
        if (o == null || getClass() != o.getClass()) return false;

        Animal model = (Animal) o;

        return Objects.equals(born, model.born) &&
        Objects.equals(deceased, model.deceased);
    }

    @Override
    public int hashCode() {
        return Objects.hash(born,
        deceased);
    }

…-client

Added so equals and hashcode is generated in models.
@github-actions github-actions bot requested a review from a team as a code owner December 23, 2024 15:32
@ricardozanini ricardozanini reopened this Dec 23, 2024
Copy link
Contributor Author

😭 Deploy PR Preview failed.

@hbelmiro hbelmiro merged commit 29f18e7 into main-lts Dec 23, 2024
10 checks passed
@hbelmiro hbelmiro deleted the main-lts_feature/add-equals-hashcode-client branch December 23, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants