Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make it possible to revert to using the v1 CRD generator #1008

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

metacosm
Copy link
Member

Note that this should only be used if a blocking issue is found with the
v2 generator because the v1 version won't be supported moving forward.

Signed-off-by: Chris Laprun claprun@redhat.com

Note that this should only be used if a blocking issue is found with the
v2 generator because the v1 version won't be supported moving forward.

Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm requested a review from a team as a code owner November 25, 2024 09:00
@metacosm metacosm self-assigned this Nov 25, 2024
@metacosm metacosm requested a review from xstefank November 25, 2024 09:00
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm merged commit 09a3598 into 6.8.x Nov 25, 2024
5 checks passed
@metacosm metacosm deleted the crd-v1-option-6.8 branch November 25, 2024 09:58
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metacosm it feels wrong that the release comes with the feature but I'm not strongly opinioned on this.

@metacosm
Copy link
Member Author

I understand the idea. On the other hand, if it can unblock some users, it's worth it, imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants