add disable property test

quarkus-qe · Dec 10, 2024 · 5723500 · 5723500
1 parent 25e1c60
commit 5723500
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -50,7 +50,7 @@ jobs:
       - name: Build in JVM mode
         shell: bash
         run: |
-          mvn -B --no-transfer-progress -fae -Dreruns=0 -s .github/quarkus-snapshots-mvn-settings.xml clean verify -am "-Dinclude.quarkus-cli-tests" -f quarkus-cli "-Dts.quarkus.cli.cmd=C:\Users\runneradmin\quarkus-dev-cli.bat" "-Ddisable-on-win-without-lang-pack"
+          mvn -B --no-transfer-progress -fae -Dreruns=0 -s .github/quarkus-snapshots-mvn-settings.xml clean verify -am "-Dinclude.quarkus-cli-tests" -f quarkus-cli "-Dts.quarkus.cli.cmd=C:\Users\runneradmin\quarkus-dev-cli.bat" "-Dts.disable-on-win-without-lang-pack"
       - name: Detect flaky tests
         id: flaky-test-detector
         if: ${{ hashFiles('**/flaky-run-report.json') != '' }}

diff --git a/quarkus-cli/src/test/java/io/quarkus/ts/quarkus/cli/QuarkusCliConfigSetIT.java b/quarkus-cli/src/test/java/io/quarkus/ts/quarkus/cli/QuarkusCliConfigSetIT.java
@@ -85,7 +85,7 @@ public void createPropertyCommand_NoSecret_ApplicationPropertiesExists() {
 
     @Order(3)
     @Test
-    @DisabledIfSystemProperty(named = "disable-on-win-without-lang-pack", matches = "true",
+    @DisabledIfSystemProperty(named = "ts.disable-on-win-without-lang-pack", matches = "true",
             disabledReason = "Some windows don't have all language pack/locales so it causing it fail")
     public void createPropertyCommand_EncryptValue_UseExistingEncryptionKey() {
         // configured props tested by SetPropertyTest#createPropertyCommand_EncryptValue_UseExistingEncryptionKey

diff --git a/quarkus-cli/src/test/java/io/quarkus/ts/quarkus/cli/QuarkusCliSpecialCharsIT.java b/quarkus-cli/src/test/java/io/quarkus/ts/quarkus/cli/QuarkusCliSpecialCharsIT.java
@@ -47,21 +47,21 @@ public void shouldCreateApplicationOnJvmWithSpecialChars() {
     }
 
     @Test
-    @DisabledIfSystemProperty(named = "disable-on-win-without-lang-pack", matches = "true",
+    @DisabledIfSystemProperty(named = "ts.disable-on-win-without-lang-pack", matches = "true",
             disabledReason = "Some windows don't have all language pack/locales so it causing it fail")
     public void shouldCreateApplicationOnJvmWithDiacritics() {
         assertCreateJavaApplicationAtFolder(FOLDER_WITH_DIACRITICS);
     }
 
     @Test
-    @DisabledIfSystemProperty(named = "disable-on-win-without-lang-pack", matches = "true",
+    @DisabledIfSystemProperty(named = "ts.disable-on-win-without-lang-pack", matches = "true",
             disabledReason = "Some windows don't have all language pack/locales so it causing it fail")
     public void shouldCreateApplicationOnJvmWithJapanese() {
         assertCreateJavaApplicationAtFolder(FOLDER_WITH_JAPANESE);
     }
 
     @Test
-    @DisabledIfSystemProperty(named = "disable-on-win-without-lang-pack", matches = "true",
+    @DisabledIfSystemProperty(named = "ts.disable-on-win-without-lang-pack", matches = "true",
             disabledReason = "Some windows don't have all language pack/locales so it causing it fail")
     public void shouldCreateApplicationOnJvmWithInternationalization() {
         assertCreateJavaApplicationAtFolder(FOLDER_WITH_INTERNATIONALIZATION);

diff --git a/quarkus-cli/src/test/java/io/quarkus/ts/quarkus/cli/config/surefire/SetPropertyTest.java b/quarkus-cli/src/test/java/io/quarkus/ts/quarkus/cli/config/surefire/SetPropertyTest.java
@@ -9,7 +9,6 @@
 
 import jakarta.inject.Inject;
 
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import io.quarkus.test.junit.QuarkusTest;
@@ -36,9 +35,8 @@ void createPropertyCommand_NoSecret_ApplicationPropertiesExists() {
     }
 
     @Test
-    @DisabledIfSystemProperty(named = "disable-on-win-without-lang-pack", matches = "true",
+    @DisabledIfSystemProperty(named = "ts.disable-on-win-without-lang-pack", matches = "true",
             disabledReason = "Some windows don't have all language pack/locales so it causing it fail")
-    @Disabled
     void createPropertyCommand_EncryptValue_UseExistingEncryptionKey() {
         assertEquals(CREATE_3.propertyValue, config.getRawValue(CREATE_3.propertyName));
     }