Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single HTTP server for gRPC services #1472

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Use single HTTP server for gRPC services #1472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build-time-analytics/src/test/java/io/quarkus/ts/buildtimeanalytics/CliDevModeIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ public void noExtensions() {
@Test
public void extensionSetA() {
QuarkusCliRestService app = createAppWithExtensions(EXTENSION_SET_A);
startDevMode(app);
// Extension set has gRPC, use new approach with single HTTP server instance
startDevMode(app.withProperty("quarkus.grpc.server.use-separate-server", "false"));
verifyValidPayloadPresent(app);
}

Expand Down
5 changes: 3 additions & 2 deletions http/http-advanced-reactive/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ HttpVersionClientServiceAsync/mp-rest/trustStore=classpath:/META-INF/resources/s
HttpVersionClientServiceAsync/mp-rest/trustStorePassword=password
# gRPC
quarkus.grpc.clients.hello.host=localhost
quarkus.grpc.clients.hello.port=${quarkus.grpc.server.port}
quarkus.grpc.clients.hello.port=${quarkus.http.port}
quarkus.grpc.server.enable-reflection-service=true
quarkus.grpc.clients.reflection-service.host=localhost
quarkus.grpc.clients.reflection-service.port=${quarkus.grpc.server.port}
quarkus.grpc.clients.reflection-service.port=${quarkus.http.port}
quarkus.grpc.server.use-separate-server=false
# authZ
quarkus.keycloak.policy-enforcer.enable=true
# Non-application endpoints. Required because we are going to force a redirection, otherwise use `/q/*` instead
Expand Down
3 changes: 2 additions & 1 deletion http/http-advanced/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ HttpVersionClientServiceAsync/mp-rest/trustStore=classpath:/META-INF/resources/s
HttpVersionClientServiceAsync/mp-rest/trustStorePassword=password
# gRPC
quarkus.grpc.clients.hello.host=localhost
quarkus.grpc.clients.hello.port=${quarkus.grpc.server.port}
quarkus.grpc.clients.hello.port=${quarkus.http.port}
quarkus.grpc.server.use-separate-server=false
# authZ
quarkus.keycloak.policy-enforcer.enable=true
# Non-application endpoints. Required because we are going to force a redirection, otherwise use `/q/*` instead
Expand Down
2 changes: 2 additions & 0 deletions monitoring/opentelemetry-reactive/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@ io.quarkus.ts.opentelemetry.reactive.sse.ServerSentEventsPongClient/mp-rest/scop

# gRPC
quarkus.grpc.clients.pong.host=localhost
quarkus.grpc.clients.pong.port=${quarkus.http.port}
quarkus.grpc.server.use-separate-server=false

quarkus.application.name=pingpong
2 changes: 2 additions & 0 deletions monitoring/opentelemetry/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@ io.quarkus.ts.opentelemetry.sse.ServerSentEventsPongClient/mp-rest/scope=jakarta

# gRPC
quarkus.grpc.clients.pong.host=localhost
quarkus.grpc.clients.pong.port=${quarkus.http.port}
quarkus.grpc.server.use-separate-server=false

quarkus.application.name=pingpong
4 changes: 3 additions & 1 deletion monitoring/opentracing-reactive-grpc/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,6 @@ io.quarkus.ts.monitoring.opentracing.reactive.grpc.ping.clients.ServerSentEvents
io.quarkus.ts.monitoring.opentracing.reactive.grpc.ping.clients.ServerSentEventsPongClient/mp-rest/scope=jakarta.inject.Singleton

# gRPC
quarkus.grpc.clients.pong.host=localhost
quarkus.grpc.clients.pong.host=localhost
quarkus.grpc.clients.pong.port=${quarkus.http.port}
quarkus.grpc.server.use-separate-server=false