-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for rest-client-reactive URL override feature #2275
base: main
Are you sure you want to change the base?
Conversation
5ff1054
to
299fead
Compare
import io.quarkus.test.services.QuarkusApplication; | ||
|
||
@QuarkusScenario | ||
public class UrlOverrideClientIT { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- What if we use non-existent url for override? How good/terrible is the error?
- Does app writes overridden URL into log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Trying to access non-existing URL causes exception on the service. It is possible to catch it and pretend it is OK, but that might cover some actual failures going on.
- No it does not not log rewriting URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I thought, that maybe we should check that error, and that it really happens, to have some non-happy-path tests. Do not know, whether it is a good idea, but please think about it.
- And what about tracing? Is there any way for an observer to distinguish these calls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing tests are good, but please consider advanced topics suggested in the comment. If you they do not make much sense in this context — you're free to merge this issue.
Summary
Implement test coverage for quarkusio/quarkus#43331
Please select the relevant options.
run tests
phrase in comment)Checklist: