Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SnappyCompressionIT as KRaft default logs directory has changed when we bumped Kafka version #2276

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Fix SnappyCompressionIT as KRaft default logs directory has changed when we bumped Kafka version #2276

merged 1 commit into from
Jan 17, 2025

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Jan 17, 2025 •
edited
Loading

Summary

Default KRaft logs dir has changed when Kafka version was bumped here quarkus-qe/quarkus-test-framework#1465. This PR fixes SnappyCompressionIT that fails the daily build.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik changed the title Fix SnappyCompressionIT as KRaft default logs dir changed when we bumped Kafka version Fix SnappyCompressionIT as KRaft default logs directory has changed when we bumped Kafka version Jan 17, 2025
jcarranzan
jcarranzan approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@jcarranzan jcarranzan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's wait for all check to pass and I'll merge it

@jcarranzan jcarranzan merged commit d365fdd into quarkus-qe:main Jan 17, 2025
7 checks passed
@michalvavrik michalvavrik deleted the feature/fix-SnappyCompressionIT branch January 17, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarranzan jcarranzan jcarranzan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @jcarranzan