Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): detect bun.lock file for the "upgrade" cmd #17775

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Dustin-Z
Copy link

@Dustin-Z Dustin-Z commented Jan 20, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

In version 1.1.39 of Bun they have introduced a text-based lockfile format (bun.lock) as an alternative to the binary lockfile (bun.lockb). It will be the default soon.
For more info see Bun's blog post.

This change will make quasar upgrade -i command detect Bun as a package manager if the new lockfile format is used.

I don't know how to test it. Can you help with with that?
I tried running my modified version in a Quasar project with pending updates using

bun ~/git/my-quasar-fork/cli/bin/quasar.js upgrade -i

But without success. It doesn't even detect my pending update. Running the original command quasar upgrade (without -i) shows that there is an update. So I don't think that's the right way to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant