add missing tests

r-lib · May 9, 2024 · 0cd6af7 · 0cd6af7
1 parent 5456d18
commit 0cd6af7
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 4 deletions.
diff --git a/R/altrep.R b/R/altrep.R
@@ -43,6 +43,16 @@ sparse_double <- function(values, positions, length) {
     )
   }
 
+  if (any(is.nan(values))) {
+    offenders <- which(is.nan(values))
+    cli::cli_abort(
+      c(
+        x = "{.arg values} must not contain NaN values.",
+        i = "NaN values at index: {offenders}."
+      )
+    )
+  }
+
   if (is.integer(values)) {
     values <- as.double(values)
   }
@@ -64,6 +74,16 @@ sparse_double <- function(values, positions, length) {
     )
   }
 
+  if (any(is.nan(positions))) {
+    offenders <- which(is.nan(positions))
+    cli::cli_abort(
+      c(
+        x = "{.arg positions} must not contain NaN values.",
+        i = "NaN values at index: {offenders}."
+      )
+    )
+  }
+
   if (!is.integer(positions)) {
     if (any(round(positions) != positions, na.rm = TRUE)) {
       offenders <- which(round(positions) != positions)

diff --git a/tests/testthat/_snaps/altrep.md b/tests/testthat/_snaps/altrep.md
@@ -36,8 +36,9 @@
     Code
       sparse_double(NaN, 1, 1)
     Condition
-      Error in `if (any(values == 0)) ...`:
-      ! missing value where TRUE/FALSE needed
+      Error in `sparse_double()`:
+      x `values` must not contain NaN values.
+      i NaN values at index: 1.
 
 ---
 
@@ -86,8 +87,9 @@
     Code
       sparse_double(1, NaN, 1)
     Condition
-      Error in `if (len_positions > 0 && max(positions) > length) ...`:
-      ! missing value where TRUE/FALSE needed
+      Error in `sparse_double()`:
+      x `positions` must not contain NaN values.
+      i NaN values at index: 1.
 
 ---