Skip to content

Commit

Permalink
Update CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
hadley committed Jan 10, 2025
1 parent 690fdb8 commit 0fa3269
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ There is one check note in this version:
File ‘testthat/libs/testthat.so’:
Found non-API calls to R: ‘SET_BODY’, ‘SET_CLOENV’, ‘SET_FORMALS’

The plan is to remove these calls in the next release, but I wanted to deprecated the problematic functions `with_mock()` and `local_mock()` first so that users get a little warning.
The plan is to remove these calls in the next minor release. I have now informed the majority of users that these functions are going away.

## revdepcheck results

We checked all reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. There were a few failures due to some new strictness and use of internal failures. I've tracked fixes for them at https://github.com/r-lib/testthat/issues/2021.
I did not check revdeps since the fixes are minor and should only decrease the number of errors.

0 comments on commit 0fa3269

Please sign in to comment.