Skip to content

Commit

Permalink
Update news and comments for release
Browse files Browse the repository at this point in the history
  • Loading branch information
jimhester committed Mar 10, 2020
1 parent d2725bf commit 60c5ab9
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 11 deletions.
9 changes: 4 additions & 5 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
# xml2 (development version)
# xml2 1.2.3

* Fix potential dangling pointer with internal `asXmlChar()` function (@michaelquinn32, #287).

* `xml_add_child()` can now create nodes with a `par` attribute. These previously errored due to partial name matching of the `parent` function in the internal `create_node()` function. (@jennybc, #285)
* `as_xml_document()` now handles cases with text nodes trailing normal nodes (#274).

* `libxml2_version()` now returns a semantic version rather than alphanumeric
version, so "2.9.10" > "2.9.9" (#277)
* `xml_add_child()` can now create nodes with a `par` attribute. These previously errored due to partial name matching of the `parent` function in the internal `create_node()` function. (@jennybc, #285)

* `as_xml_document()` now handles cases with text nodes trailing normal nodes (#274).
* `libxml2_version()` now returns a semantic version rather than alphanumeric version, so "2.9.10" > "2.9.9" (#277)

# xml2 1.2.2

Expand Down
12 changes: 6 additions & 6 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
## Release summary

This is a path release fixing a minor issue in the previous release
This is a patch release fixing CRAN failures

## Test environments

* local OS X install, R 3.6.1.
* Ubuntu 12.04 (on travis-ci), R-oldrel, R-release, R-devel
* Windows Server 2012 R2 (x64), R 3.6.1
* local macOS install, R 3.6.2.
* Ubuntu 14.04 (on travis-ci), R-oldrel, R-release, R-devel
* Windows Server 2012 R2 (x64), R 3.6.2
* Rhub

## R CMD check results
There were no ERRORs or WARNINGs.

There were 2 NOTEs:
There were 1 NOTEs:

* checking installed package size ... NOTE
installed size is 6.7Mb
Expand All @@ -24,6 +24,6 @@ There were 2 NOTEs:


## Downstream dependencies
I ran `R CMD check` on all 305 reverse dependencies (https://github.com/r-lib/xml2/tree/master/revdep#readme).
I ran `R CMD check` on all reverse dependencies (https://github.com/r-lib/xml2/tree/master/revdep#readme).

There were no breaking changes with this release.

0 comments on commit 60c5ab9

Please sign in to comment.