Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #46 #47

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix issue #46 #47

merged 1 commit into from
Oct 31, 2023

Conversation

pitkant
Copy link
Member

@pitkant pitkant commented Jun 29, 2023

Fixes latter part of the issue described in #46 by making subsetting of columns less rigid in case of different column names between different years. What prompted this change was that sairaanhoitop_code column is missing from the most recent year 2023, which caused the following error in convert_municipality_key_codes function:

muns1 <- geofi::get_municipalities(codes_as_character = TRUE, year = 2023)

Error in `muni_key[, width_2]`:
! Can't subset columns that don't exist.
✖ Column `sairaanhoitop_code` doesn't exist.

@pitkant pitkant requested a review from muuankarski June 29, 2023 12:35
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #47 (0d6c4c7) into master (4173fd0) will decrease coverage by 2.67%.
The diff coverage is 0.00%.

❗ Current head 0d6c4c7 differs from pull request most recent head 983b99c. Consider uploading reports for the commit 983b99c to get more accurate results

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   58.21%   55.55%   -2.67%     
==========================================
  Files           9        9              
  Lines         146      153       +7     
==========================================
  Hits           85       85              
- Misses         61       68       +7     
Impacted Files Coverage Δ
R/convert_codes_as_character.R 0.00% <0.00%> (ø)

@muuankarski muuankarski merged commit e0784a1 into master Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants