Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the autoconf process. #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jlm
Copy link

@jlm jlm commented Jan 20, 2025

Update the README to describe how to run autoconf to generate the ./configure script.

@stappersg
Copy link
Member

stappersg commented Jan 20, 2025

It is better as #258 and should be improved:

  • Split in "Fear mongering you need Docker" and "Updating the README"
  • Add commit messages to the commit summary
  • Add sign off by

@stappersg
Copy link
Member

stappersg commented Jan 20, 2025

And I don't like the white space change.

@jlm if the white space change is important for you, document the why in the commit message. (Preferable in a separate merge request.)

@robbat2
Copy link
Member

robbat2 commented Jan 21, 2025

The whitespace change is fine with me, as we could probably change this to markdown in future.

However it does need a DCO-style signed-off-by line on the PR & commit.

@jlm
Copy link
Author

jlm commented Jan 23, 2025

The whitespace is unimportant to me. I think the text explaining how to do it without Docker is worthwhile; I built it on a FreeBSD-based router which had a processor on which Docker was not really practical and someone else might want to do that. The main value of my change is simply that one should run ./autogen-container.sh prior to configure.

Unfortunately I am not familiar with the DCO-style "Signed-off by" line, and don't know how to do that. I am happy for someone else to do that or tell me what to put in more detail.

@robbat2
Copy link
Member

robbat2 commented Jan 24, 2025

The whitespace is unimportant to me. I think the text explaining how to do it without Docker is worthwhile; I built it on a FreeBSD-based router which had a processor on which Docker was not really practical and someone else might want to do that.

The source tarball should already have autoconf & automake completed - did it not work in your environment? [you did not specify if you were building from source].

Unfortunately I am not familiar with the DCO-style "Signed-off by" line, and don't know how to do that. I am happy for someone else to do that or tell me what to put in more detail.

https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants