Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 🖥︎ in welcome message #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

is-this-c
Copy link
Contributor

I do not like how server messages are not differentiated from operator messages but I am not sure how to resolve. The welcome message can be anything however so I think it needs differentiation with 🖥︎ .

@GooberRF
Copy link
Contributor

I don't necessarily disagree with this change - I just think it's alone kind of... pointless? It causes no harm of course, but I don't think it does anything to solve the problem.

Perhaps on the client, when displaying chat messages from the server, if the message is prefixed with 🖥︎, the client could display it as

🖥︎: This is a message

rather than the current

Server: 🖥︎ This is a message

I'm still not convinced this is the best way to handle this (ideally I'd like to give the server the ability to display messages to the client that are not in the chat box - for welcome messages, vote notifications, etc.) But I think it might be better? Of course chat messages sent from the server operator would still be show as Server:

@is-this-c
Copy link
Contributor Author

is-this-c commented Dec 16, 2024

This PR does not try to be a complete solution. But it is not pointless. Currently welcome messages may look like messages from an operator which has potential to confuse people.

🖥︎: is kind of weird and does not really appeal to me and moreover other players technically can use 🖥︎ as their name.

I did think about messages from an operator showing as Operator:.

Edit:

ideally I'd like to give the server the ability to display messages to the client that are not in the chat box - for welcome messages, vote notifications, etc.

Interesting (I assume under the chat box?) but probably more distracting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants