-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 2488: boundary diagram updates #2770
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2770 +/- ##
===========================================
+ Coverage 92.80% 93.08% +0.27%
===========================================
Files 246 246
Lines 5576 5611 +35
Branches 480 491 +11
===========================================
+ Hits 5175 5223 +48
+ Misses 308 290 -18
- Partials 93 98 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…/TANF-app into doc/bd-update-sendgrid
@@ -18,17 +18,17 @@ Developers will deploy new code through GitHub, initiating the continuous integr | |||
|
|||
### User access | |||
|
|||
All web users will log into the system through their web browsers. | |||
All web users will log into the system through their web browsers. An [Nginx server](../../tdrs-frontend/nginx/README.md) sits in front of each frontend application to serve as a reverse proxy to block traffic to TDP from outside the US/US territories. For traffic *within* the US/US territories: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main reason of having that Nginx is to serve the frontend app, so I suggest changing the wording to:
"All web users will log into the system through their web browsers. An Nginx server sits in front of each frontend application to serve the frontend application as well as acting as a reverse proxy which blocks traffic to TDP from outside the US/US territories. For traffic within the US/US territories:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@raftmsohani can you merge this one when you get a chance? |
Summary of Changes
Pull request closes #2488
How to Test
List the steps to test the PR
These steps are generic, please adjust as necessary.
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):