2592/separate celery #2773
2592/separate celery #2773
Conversation
…ocument saving and searching in s3
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2773 +/- ##
===========================================
+ Coverage 93.67% 93.76% +0.09%
===========================================
Files 262 219 -43
Lines 6053 5087 -966
Branches 503 348 -155
===========================================
- Hits 5670 4770 -900
+ Misses 287 254 -33
+ Partials 96 63 -33
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 44 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…n order to expose the flower /metrics endpoint
| @@ -39,6 +39,6 @@ variable "cf_user" { | |||
|
|
|||
| variable "dev_app_names" { | |||
| type = list(string) | |||
| description = "list of app names deployed in the dev environment" | |||
| description = "list of app names deployed in the dev cf space" | |||
| default = ["a11y", "qasp", "raft", "sandbox"] | |||
There was a problem hiding this comment.
have one redis service per environment (dev, staging, prod) vs one per backend (use channel filter)
scripts/deploy-backend.sh
Outdated
|
|
||
| # bind to redis | ||
| cf bind-service "$CGAPPNAME_BACKEND" "tdp-redis-${ENV}" | ||
| cf bind-service "$CGAPPNAME_CELERY" "tdp-redis-${ENV}" |
| cf-space: | ||
| default: tanf-dev | ||
| type: string | ||
| environment: |
There was a problem hiding this comment.
does this mean it only deploys for raft? or it's only the default
|
this is opening up celery monitoring tool (flower) to public so we will need to public:https://tdp-celery-sandbox.app.cloud.gov as it is configured. Additionally, need to add commands to documentation, needed to create route, etc |
| resource "cloudfoundry_service_instance" "redis" { | ||
| name = "tdp-redis-prod" | ||
| space = data.cloudfoundry_space.space.id | ||
| service_plan = data.cloudfoundry_service.redis.service_plans["PLACEHOLDER"] |
Summary of Changes
This PR uses terraform to create a redis service and an celery app instance per environment instead of hosting all that on the backend app instance. It updates environment variables in order to connect to the new service for both the backend and celery apps.
How to Test
List the steps to test the PR
When deployed to an environment, it should create the redis servers for the space and celery instance for the env. Both the backend app and the celery should be able to communicate with the redis service for it's environment.
Local testing should remain the same.
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlichand/oradpenningtonconfirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Reportcomment in PR)CodeCov Reportcomment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjollyandttran-hubusing Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):