-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datafile Parse Latency Bug #2778
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2778 +/- ##
===========================================
- Coverage 92.80% 92.78% -0.02%
===========================================
Files 246 246
Lines 5576 5575 -1
Branches 480 479 -1
===========================================
- Hits 5175 5173 -2
- Misses 308 309 +1
Partials 93 93
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
…2777-print-bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the quick fix @elipe17
logs a lot less cluttered when hitting the data files page in DAC 🚀
14:06:08.747243+00:00
09:06:08.748: [APP/PROC/WEB.0] 10.255.222.82 - - [13/Dec/2023:14:06:08 +0000] "GET /v1/auth_check HTTP/1.0" 200 1097 "https://tdp-frontend-qasp.app.cloud.gov/data-files" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36"
09:06:09.017: [APP/PROC/WEB.0] 10.255.222.82 - - [13/Dec/2023:14:06:09 +0000] "GET /admin/data_files/datafile/ HTTP/1.0" 200 122223 "https://tdp-frontend-qasp.app.cloud.gov/admin/" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36"
09:06:10.482: [APP/PROC/WEB.0] [2023-12-13 14:06:10 +0000] [130] [DEBUG] GET /admin/parsers/parsererror/
09:06:10.605: [APP/PROC/WEB.0] 10.255.222.82 - - [13/Dec/2023:14:06:10 +0000] "GET /admin/parsers/parsererror/?file=55 HTTP/1.0" 200 74901 "https://tdp-frontend-qasp.app.cloud.gov/admin/data_files/datafile/" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36"
09:06:10.727: [APP/PROC/WEB.0] [2023-12-13 14:06:10 +0000] [130] [DEBUG] GET /admin/jsi18n/
09:06:10.766: [APP/PROC/WEB.0] 10.255.222.82 - - [13/Dec/2023:14:06:10 +0000] "GET /admin/jsi18n/ HTTP/1.0" 200 3195 "https://tdp-frontend-qasp.app.cloud.gov/admin/parsers/parsererror/?file=55" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36"
09:06:25.976: [APP/PROC/WEB.0] [2023-12-13 14:06:25 +0000] [132] [DEBUG] GET /admin/data_files/datafile/
09:06:26.880: [APP/PROC/WEB.0] 10.255.222.82 - - [13/Dec/2023:14:06:26 +0000] "GET /admin/data_files/datafile/ HTTP/1.0" 200 122223 "https://tdp-frontend-qasp.app.cloud.gov/admin/" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36"
Summary of Changes
Pull request closes [SPIKE] Investigate latency in data files model #2777
How to Test
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):