Refine labels and text for Data Files search controls

[elipe17]

Summary of Changes

• Updated labels
• Updated error message
• Updated tests
  Pull request closes Refine labels and text for Data Files search controls #2699

How to Test

cd tdrs-frontend && docker-compose up --build
cd tdrs-backend && docker-compose up

1. Open http://localhost:3000/ and sign in.
2. Go to the Data Files page
3. Verify new paragraph text is there
4. Click the 'Search' button with various selections of the required fields and verify the error messages are correct along with the error count

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

• Add the following paragraph text under the Data Files heading and before the first form input:
• "Fields marked with an asterisk (*) are required."
• Add required asterisks to all fields, including the STT field for OFA users, which should already have one.
• Change the label for the Quarter dropdown to: "Fiscal Quarter*".
• Ensure that existing form validation rules remain unchanged:
• Only show relevant fields to each user group.
• Only count visible errors in the error summary (fields not visible to the user should not be counted as errors).
• Run the Testing Checklist to confirm all tests pass.
• Update the README if necessary, to reflect changes to the form or labels.

Deliverable 2: Tested Code

• Are all areas of code introduced in this PR meaningfully tested?
  • If this PR introduces backend code changes, are they meaningfully tested?
  • If this PR introduces frontend code changes, are they meaningfully tested?
• Are code coverage minimums met?
  • Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
  • Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

• Are backend code style checks passing on CircleCI?
• Are frontend code style checks passing on CircleCI?
• Are code maintainability principles being followed?

Deliverable 4: Accessible

• Does this PR complete the epic?
• Are links included to any other gov-approved PRs associated with epic?
• Does PR include documentation for Raft's a11y review?
• Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

• Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

• Does this PR provide background for why coding decisions were made?
• If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
• If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
• If this PR introduces dependencies, are their licenses documented?
• Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

• Does the OWASP Scan pass on CircleCI?
• Do manual code review and manual testing detect any new security issues?
• If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

• the purpose of the research
• methods used to conduct the research
• who participated in the research
• what was tested and how
• impact of research on TDP
• (if applicable) final design mockups produced for TDP development

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.38%. Comparing base (9d2e2eb) to head (f6b83cc).
Report is 4 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3394   +/-   ##
========================================
  Coverage    91.38%   91.38%           
========================================
  Files          299      299           
  Lines         8614     8614           
  Branches       640      640           
========================================
  Hits          7872     7872           
  Misses         622      622           
  Partials       120      120           

Flag	Coverage Δ
dev-backend	91.24% <ø> (ø)
dev-frontend	92.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
tdrs-frontend/src/components/Reports/Reports.jsx	87.61% <ø> (ø)
...rontend/src/components/STTComboBox/STTComboBox.jsx	90.90% <100.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f748ba5...f6b83cc. Read the comment docs.

[raftmsohani]

LGTM!

[victoriaatraft]

[ADPennington]

LGTM 🚀

cc: @klinkoberstar @victoriaatraft in case this change needs to be captured in release notes? seems minor?

s= staging (the current state)
q = qasp (this PR)

admin view

STT view