Add the smove method to Kredis::Types::Set #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the Redis documentation currently supports the use of the `smove` method, this change make that method also available in kredis
example:
my_kredis_set.smove(another_kredis_set.key, value_to_move)
use case:
when using sets as queues for a multi step process it is helpful to move values between sets:
queued -> issued
issued -> completed
issued -> failed & add back to queued for retying
https://redis.io/docs/latest/commands/smove/
Add smove test coverage
Add 'smove' method to Kredis::Types::Set
CoderMiguel
commented
Jan 24, 2025
| @@ -3,7 +3,7 @@ | |||
| class Kredis::Types::Set < Kredis::Types::Proxying | |||
| prepend Kredis::DefaultValues | |||
|
|
|||
| proxying :smembers, :sadd, :srem, :multi, :del, :sismember, :scard, :spop, :exists?, :srandmember | |||
| proxying :smembers, :sadd, :srem, :multi, :del, :sismember, :scard, :spop, :exists?, :srandmember, :smove | |||
|
|
|||
| attr_accessor :typed | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| def move(set, member) | |
| destination = set.respond_to?(:key) ? set.key : set | |
| smove(destination, member) | |
| end |
Comment on lines
+104
to
+112
| test "smove" do | ||
| @set.add(%w[ 1 2 ]) | ||
| another_set = Kredis.set "another_set" | ||
| another_set.add(%w[ 3 ]) | ||
|
|
||
| assert @set.smove(another_set.key, "2") | ||
| assert_equal %w[ 1 ], @set.members | ||
| assert_equal %w[ 2 3 ], another_set.members | ||
| end |
There was a problem hiding this comment.
Suggested change
| test "smove" do | |
| @set.add(%w[ 1 2 ]) | |
| another_set = Kredis.set "another_set" | |
| another_set.add(%w[ 3 ]) | |
| assert @set.smove(another_set.key, "2") | |
| assert_equal %w[ 1 ], @set.members | |
| assert_equal %w[ 2 3 ], another_set.members | |
| end | |
| test "smove" do | |
| @set.add(%w[ 1 2 ]) | |
| another_set = Kredis.set "another_set" | |
| another_set.add(%w[ 3 ]) | |
| assert @set.smove(another_set.key, "2") | |
| assert_equal %w[ 1 ], @set.members | |
| assert_equal %w[ 2 3 ], another_set.members | |
| end | |
| test "move with set" do | |
| @set.add(%w[ x y ]) | |
| another_set = Kredis.set "another_set" | |
| another_set.add(%w[ z ]) | |
| assert @set.move(another_set, "y") | |
| assert_equal %w[ x ], @set.members | |
| assert_equal %w[ y z ], another_set.members | |
| end | |
| test "move with key" do | |
| @set.add(%w[ a b ]) | |
| another_set = Kredis.set "another_set" | |
| another_set.add(%w[ c ]) | |
| assert @set.move(another_set.key, "b") | |
| assert_equal %w[ a ], @set.members | |
| assert_equal %w[ b c ], another_set.members | |
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis documentation currently supports the use of the
smovemethod, this change makes that method available in Kredishttps://redis.io/docs/latest/commands/smove/