Skip to content

Commit

Permalink
Fix image name and tag for release (#120)
Browse files Browse the repository at this point in the history
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
  • Loading branch information
Danil-Grigorev authored Nov 28, 2024
1 parent 7c78694 commit 340d059
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ on:
- "v*.*.*"

env:
IMAGE_NAME: ${{ github.repository }}
TAG: ${{ github.ref_name }}
IMAGE_NAME: ${{ github.repository_owner }}/cluster-api-addon-provider-fleet
REGISTRY: ghcr.io

jobs:
Expand Down Expand Up @@ -55,7 +56,6 @@ jobs:
run: |
# this is quite naive, but i don't think we need more for now
sed -i "s/dev/${TAG}/g" config/default/manager_image_patch.yaml
sed -i "s/dev/${TAG}/g" config/default/helm_manager_image_patch.yaml
just release-manifests
- name: Release
uses: softprops/action-gh-release@v2
Expand Down
2 changes: 1 addition & 1 deletion Tiltfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ features = cfg.get('features', "")
print("compiling with features: {}".format(features))

local_resource('compile', 'just create-out-dir compile %s' % features)
docker_build('ghcr.io/rancher-sandbox/cluster-api-fleet-controller', '.', dockerfile='Dockerfile')
docker_build('ghcr.io/rancher-sandbox/cluster-api-addon-provider-fleet', '.', dockerfile='Dockerfile')
yaml = kustomize('config/default')
k8s_yaml(yaml)
k8s_resource('caapf-controller-manager')
4 changes: 2 additions & 2 deletions config/default/manager_image_patch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ spec:
template:
spec:
containers:
- image: ghcr.io/rancher-sandbox/cluster-api-fleet-controller:dev
- image: ghcr.io/rancher-sandbox/cluster-api-addon-provider-fleet:dev
name: manager
- image: ghcr.io/rancher-sandbox/cluster-api-fleet-controller:dev
- image: ghcr.io/rancher-sandbox/cluster-api-addon-provider-fleet:dev
name: helm-manager
2 changes: 1 addition & 1 deletion justfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
NAME := "cluster-api-fleet-controller"
NAME := "cluster-api-addon-provider-fleet"
KUBE_VERSION := env_var_or_default('KUBE_VERSION', '1.30.0')
ORG := "ghcr.io/rancher-sandbox"
TAG := "dev"
Expand Down

0 comments on commit 340d059

Please sign in to comment.