Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): field selectors #49

Merged
merged 4 commits into from
Nov 28, 2024
Merged

fix(storage): field selectors #49

merged 4 commits into from
Nov 28, 2024

Conversation

fabriziosestito
Copy link
Collaborator

  • selectable fields were wrong in the getAttrs func
  • vulnerability report didn't have field label conversion
  • vulnerability report test CRD was missing selectable fields

@fabriziosestito
fix(storage): add missing field label conversion to VulnerabilityReport
d70f164 
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
@fabriziosestito
test: add selectable fields to VulnerabilityReport test CRD
d00e760 
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
@fabriziosestito
f
2578826 
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
@fabriziosestito
fix(storage): selectable fields were wrong
3ef10ec 
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
@fabriziosestito fabriziosestito added bug Something isn't working storage labels Nov 28, 2024
@fabriziosestito fabriziosestito self-assigned this Nov 28, 2024
@fabriziosestito fabriziosestito added this to the MVP milestone Nov 28, 2024
flavio
flavio approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fixes!

@flavio flavio merged commit 9ce0cd9 into rancher-sandbox:main Nov 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavio flavio flavio approved these changes

Assignees

@fabriziosestito fabriziosestito

Labels
bug Something isn't working storage
Projects
None yet
Milestone
POC
Development

Successfully merging this pull request may close these issues.
2 participants
@fabriziosestito @flavio