Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2.8] UnRC webhook 0.4.14 #4885

Merged
merged 3 commits into from
Dec 18, 2024
Merged

[v2.8] UnRC webhook 0.4.14 #4885

merged 3 commits into from
Dec 18, 2024

Conversation

nflynt
Copy link
Contributor

@nflynt nflynt commented Dec 18, 2024

@nflynt nflynt requested a review from a team as a code owner December 18, 2024 00:11
@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@brudnak brudnak self-requested a review December 18, 2024 01:06
brudnak
brudnak previously requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@brudnak brudnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@nflynt nflynt dismissed brudnak’s stale review December 18, 2024 14:13

feedback addressed offline

@nflynt nflynt merged commit 3c672ef into rancher:dev-v2.8 Dec 18, 2024
4 checks passed
@nflynt nflynt mentioned this pull request Dec 18, 2024
Merged
nicholasSUSE pushed a commit that referenced this pull request Dec 18, 2024
@nflynt @nicholasSUSE
[v2.8] UnRC webhook 0.4.14 (#4885)
dbb32a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prachidamle prachidamle prachidamle approved these changes

@brudnak brudnak brudnak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nflynt @prachidamle @brudnak