Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.11] prometheus-federator update #4909

Closed

Conversation

mallardduck
Copy link
Member

@mallardduck mallardduck commented Dec 23, 2024

Update the RC after initial QA validation.

NOTE: Just realized that I've been using a 2.10 version for the chart, I think 2.11 should have been a 106 chart? No sweat either way since 2.11 is pretty far out and this can be adjusted to correct version as needed.

Due to this when I backport for 2.10 I'll just reuse the same version as the one here. And if we do a 2.9 backport it would decrement to 104 base version.

@mallardduck mallardduck requested a review from a team as a code owner December 23, 2024 17:59
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@mallardduck mallardduck changed the title [dev-v2.11] prometheus-federator update 105.1.0-rc.1+up0.4.5 [dev-v2.11] prometheus-federator update Dec 23, 2024
@mallardduck mallardduck force-pushed the prom-fed-upstream-unrc branch from 090f7d5 to fb0ee52 Compare January 7, 2025 22:13
Copy link

github-actions bot commented Jan 7, 2025

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@mallardduck
Copy link
Member Author

This chart did pass QA to be able to un-RC however as @joshmeranda pointed out I did the double RC thing on accident. Something we have an exception for with monitoring related charts. Also I noticed after the process that the version I picked would match 2.10 not 2.11.

Due to those hiccups I'm going to opt to remove the chart and add a non-RC'd one in a follow up PR. Follow up to remove charts here: #4930

@mallardduck mallardduck closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant