Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.10] rancher-vsphere-csi 105.1.0+up3.3.1-rancher7 add #4912

Merged

Conversation

pedromfcarvalho
Copy link
Contributor

@pedromfcarvalho pedromfcarvalho commented Dec 23, 2024

This incorporates this upstream change:

Issue: rancher/rancher#48053

Engineeering testing

For testing that this latest bump had an effect, I installed the csi chart in the local cluster, even though it wasn't a vsphere cluster, because it was still possible to verify that arguments could be passed. To do this, I customized the following values before installing the chart (directly in the value yaml view):

csiController:
  csiResizer:
    enabled: true
  image:
    additionalArgs: ["-version"]
    csiAttacher:
      additionalArgs: ["--logging-format=json"]
    csiProvisioner:
      additionalArgs: ["--version"]
    csiResizer:
      additionalArgs: ["--logging-format=json"]
    csiSnapshotter:
      additionalArgs: ["-version"
    livenessProbe:
      additionalArgs: ["--logging-format=json"]
    vsphereSyncer:
      additionalArgs: ["-version"]

csiNode:
  image:
    additionalArgs: ["-version"]
    livenessProbe:
      additionalArgs: ["--logging-format=json"]
    nodeDriverRegistrar:
      additionalArgs: ["--logging-format=json"]

blockVolumeSnapshot:
  enabled: true

Note that these values have to be configured individually, and the other ones left as they are. The point is to pass additional args to every container. It's also necessary to enable the csi resizer and block volume snapshots so two of the containers run.

After this, I checked the logs every container for one controller deployment and the single node deployment (a total of 10 containers). Those that were passed --logging-format=json had json output in their logs, and those that were passed -version/--version printed their version before exiting. Most containers failed because this was not run in a vsphere environment, but it was sufficient to verify that the arguments were being passed correctly.

QA considerations

Test suggestions:

  • The checks from engineering testing above, to verify the effects of this bump
  • Any other usual vsphere CSI tests not specific to this bump to check for regressions

Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Copy link

github-actions bot commented Jan 3, 2025

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@pedromfcarvalho pedromfcarvalho marked this pull request as ready for review January 6, 2025 13:47
@pedromfcarvalho pedromfcarvalho requested a review from a team as a code owner January 6, 2025 13:47
@jiaqiluo jiaqiluo requested a review from a team January 7, 2025 17:32
Copy link

github-actions bot commented Jan 7, 2025

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

release.yaml Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jan 7, 2025

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@pedromfcarvalho pedromfcarvalho merged commit ffb4dca into rancher:dev-v2.10 Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants