-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-v2.10] rancher-vsphere-csi 105.1.0+up3.3.1-rancher7 add #4912
Merged
pedromfcarvalho
merged 5 commits into
rancher:dev-v2.10
from
pedromfcarvalho:bump-vsphere-csi-v2.10
Jan 7, 2025
Merged
[dev-v2.10] rancher-vsphere-csi 105.1.0+up3.3.1-rancher7 add #4912
pedromfcarvalho
merged 5 commits into
rancher:dev-v2.10
from
pedromfcarvalho:bump-vsphere-csi-v2.10
Jan 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
pedromfcarvalho
force-pushed
the
bump-vsphere-csi-v2.10
branch
from
January 3, 2025 19:07
931b80e
to
26ca9aa
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
jiaqiluo
requested changes
Jan 7, 2025
pedromfcarvalho
force-pushed
the
bump-vsphere-csi-v2.10
branch
from
January 7, 2025 17:55
26ca9aa
to
f053c1b
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
jiaqiluo
requested changes
Jan 7, 2025
pedromfcarvalho
force-pushed
the
bump-vsphere-csi-v2.10
branch
from
January 7, 2025 18:11
f053c1b
to
dc0b732
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
jiaqiluo
approved these changes
Jan 7, 2025
HarrisonWAffel
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates this upstream change:
Issue: rancher/rancher#48053
Engineeering testing
For testing that this latest bump had an effect, I installed the csi chart in the local cluster, even though it wasn't a vsphere cluster, because it was still possible to verify that arguments could be passed. To do this, I customized the following values before installing the chart (directly in the value yaml view):
Note that these values have to be configured individually, and the other ones left as they are. The point is to pass additional args to every container. It's also necessary to enable the csi resizer and block volume snapshots so two of the containers run.
After this, I checked the logs every container for one controller deployment and the single node deployment (a total of 10 containers). Those that were passed
--logging-format=json
had json output in their logs, and those that were passed-version/--version
printed their version before exiting. Most containers failed because this was not run in a vsphere environment, but it was sufficient to verify that the arguments were being passed correctly.QA considerations
Test suggestions: